Bug#1065046: ace-of-penguins: FTBFS on armhf with implicit function declaration

[Steve Langasek]

Package: ace-of-penguins
Version: 1.5~rc2-5
Severity: serious
Tags: patch
Justification: ftbfs
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu noble ubuntu-patch

Dear maintainers,

In Ubuntu we see that ace-of-penguins now fails to build on armhf, because
the 64-bit time_t transition means requires
-Werror=implicit-function-declaration to ensure packages pick up the correct
time64 glibc entry point mappings from the headers.

The failure is:

[...]
./make-imglib.c: In function ‘tokenize’:
./make-imglib.c:207:20: error: implicit declaration of function ‘isgraph’ [-Werror=implicit-function-declaration]
  207 |   while (*next && !isgraph(*next)) next++;
      |                    ^~~~~~~
./make-imglib.c:10:1: note: include ‘<ctype.h>’ or provide a declaration of ‘isgraph’
[...]

  (https://launchpad.net/ubuntu/+source/ace-of-penguins/1.5~rc2-5build1/+build/27848688)

Seems easy enough, gcc even tells us which header is missing!  See attached
a patch for this which has been uploaded to Ubuntu.

Thanks for considering,
-- 
Steve Langasek                   Give me a lever long enough and a Free OS
Debian Developer                   to set it on, and I can move the world.
Ubuntu Developer                                   https://www.debian.org/
slangasek at ubuntu.com                                     vorlon at debian.org
-------------- next part --------------
diff -Nru ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch
--- ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch	1969-12-31 16:00:00.000000000 -0800
+++ ace-of-penguins-1.5~rc2/debian/patches/no-implicit-function-declaration.patch	2024-02-28 23:00:10.000000000 -0800
@@ -0,0 +1,19 @@
+Description: fix missing function declaration
+ 64-bit time_t requires use of -Werror=implicit-function-declaration,
+ and we have one here - isgraph().  Include the standard header to fix
+ the build failure.
+Author: Steve Langasek <steve.langasek at canonical.com>
+Last-Update: 2024-02-28
+Forwarded: no
+Index: ace-of-penguins-1.5~rc2/lib/make-imglib.c
+===================================================================
+--- ace-of-penguins-1.5~rc2.orig/lib/make-imglib.c
++++ ace-of-penguins-1.5~rc2/lib/make-imglib.c
+@@ -5,6 +5,7 @@
+ #include <sys/stat.h>
+ #include <unistd.h>
+ #include <dirent.h>
++#include <ctype.h>
+ 
+ #include <png.h>
+ 
diff -Nru ace-of-penguins-1.5~rc2/debian/patches/series ace-of-penguins-1.5~rc2/debian/patches/series
--- ace-of-penguins-1.5~rc2/debian/patches/series	2023-01-13 13:59:18.000000000 -0800
+++ ace-of-penguins-1.5~rc2/debian/patches/series	2024-02-28 22:58:12.000000000 -0800
@@ -1,2 +1,3 @@
 freecell-KDE.patch
 gcc10.patch
+no-implicit-function-declaration.patch