Bug#1074943: fairymax: ftbfs with GCC-14

[Matthias Klose]

Package: src:fairymax
Version: 5.0b-1
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/fairymax_5.0b-1_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
SCHROOT_GROUP=user42
SCHROOT_SESSION_ID=sid-amd64-sbuild-f63009fb-7e65-478c-8ead-7b27591a5b1a
SCHROOT_UID=1001
SCHROOT_USER=user42
SHELL=/bin/sh
USER=user42

dpkg-buildpackage
-----------------

Command: dpkg-buildpackage --sanitize-env -us -uc -b -rfakeroot
dpkg-buildpackage: info: source package fairymax
dpkg-buildpackage: info: source version 5.0b-1
dpkg-buildpackage: info: source distribution unstable
dpkg-buildpackage: info: source changed by Vincent Legout <vlegout at debian.org>
 dpkg-source --before-build .
dpkg-buildpackage: info: host architecture amd64
 fakeroot debian/rules clean
dh clean
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_auto_clean
dh_auto_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1 clean
make[1]: Entering directory '/<<PKGBUILDDIR>>'
rm -f fairymax shamax maxqi fairymax.6.gz
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
   dh_clean
dh_clean: warning: Compatibility levels before 10 are deprecated (level 9 in use)
 debian/rules build
dh build
dh: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_update_autotools_config
   dh_auto_configure
dh_auto_configure: warning: Compatibility levels before 10 are deprecated (level 9 in use)
   dh_auto_build
dh_auto_build: warning: Compatibility levels before 10 are deprecated (level 9 in use)
	make -j1
make[1]: Entering directory '/<<PKGBUILDDIR>>'
cc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -Wl,-z,relro -Wl,-z,now -Wdate-time -D_FORTIFY_SOURCE=2 -DFAIRYDIR=\"/usr/share/games/fairymax\" fairymax.c -o fairymax
fairymax.c:176:1: error: return type defaults to ‘int’ [-Wimplicit-int]
  176 | D(k,q,l,e,E,z,n)        /* recursive minimax search, k=moving side, n=depth*/
      | ^
fairymax.c: In function ‘PrintVariants’:
fairymax.c:477:28: error: ‘return’ with a value, in function returning void [-Wreturn-mismatch]
  477 |         if(f==NULL) return 0;
      |                            ^
fairymax.c:471:6: note: declared here
  471 | void PrintVariants(int combo)
      |      ^~~~~~~~~~~~~
fairymax.c: In function ‘LoadGame’:
fairymax.c:552:27: error: ‘return’ with a value, in function returning void [-Wreturn-mismatch]
  552 |                    return 0; /* keep old settings */
      |                           ^
fairymax.c:524:6: note: declared here
  524 | void LoadGame(char *name)
      |      ^~~~~~~~
fairymax.c:562:16: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  562 |         i = 1; fscanf(f, "=%d", &i); zone = i - 1;       // new method to indicate deviant zone depth
      |                ^~~~~~~~~~~~~~~~~~~~
fairymax.c:564:29: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  564 |         for(i=0; i<BW; i++) fscanf(f, "%d", oo+i);
      |                             ^~~~~~~~~~~~~~~~~~~~~
fairymax.c:565:29: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  565 |         for(i=0; i<BW; i++) fscanf(f, "%d", oo+i+16);
      |                             ^~~~~~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:19: fairymax] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:6: build] Error 255
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2