Bug#1074967: freeorion: ftbfs with GCC-14

[Matthias Klose]

Package: src:freeorion
Version: 0.5+git20230820-4
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/freeorion_0.5+git20230820-4_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp: In function ‘condition_wrapper {anonymous}::insert_resource_supply_connected_(const boost::python::tuple&, const boost::python::dict&)’:
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:638:83: note: ‘<anonymous>’ declared here
  638 |         auto condition = boost::python::extract<condition_wrapper>(kw["condition"])();
      |                                                                                   ^
In copy constructor ‘std::__shared_count<_Lp>::__shared_count(const std::__shared_count<_Lp>&) [with __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’,
    inlined from ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(const std::__shared_ptr<_Tp, _Lp>&) [with _Tp = const Condition::Condition; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’ at /usr/include/c++/14/bits/shared_ptr_base.h:1523:7,
    inlined from ‘std::shared_ptr<_Tp>::shared_ptr(const std::shared_ptr<_Tp>&) [with _Tp = const Condition::Condition]’ at /usr/include/c++/14/bits/shared_ptr.h:203:7,
    inlined from ‘condition_wrapper::condition_wrapper(const condition_wrapper&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.h:15:8,
    inlined from ‘condition_wrapper {anonymous}::insert_resource_supply_connected_(const boost::python::tuple&, const boost::python::dict&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:638:85:
/usr/include/c++/14/bits/shared_ptr_base.h:1073:19: warning: ‘((const std::__shared_count<__gnu_cxx::_S_atomic>*)((char*)&<unnamed> + offsetof(boost::python::extract<condition_wrapper>,boost::python::extract<condition_wrapper>::<unnamed>.boost::python::converter::extract_rvalue<condition_wrapper>::m_data.boost::python::converter::rvalue_from_python_data<condition_wrapper>::<unnamed>.boost::python::converter::rvalue_from_python_storage<condition_wrapper>::storage)))[1].std::__shared_count<>::_M_pi’ may be used uninitialized [-Wmaybe-uninitialized]
 1073 |       : _M_pi(__r._M_pi)
      |               ~~~~^~~~~
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp: In function ‘condition_wrapper {anonymous}::insert_resource_supply_connected_(const boost::python::tuple&, const boost::python::dict&)’:
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:638:83: note: ‘<anonymous>’ declared here
  638 |         auto condition = boost::python::extract<condition_wrapper>(kw["condition"])();
      |                                                                                   ^
In copy constructor ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(const std::__shared_ptr<_Tp, _Lp>&) [with _Tp = const Condition::Condition; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’,
    inlined from ‘std::shared_ptr<_Tp>::shared_ptr(const std::shared_ptr<_Tp>&) [with _Tp = const Condition::Condition]’ at /usr/include/c++/14/bits/shared_ptr.h:203:7,
    inlined from ‘condition_wrapper::condition_wrapper(const condition_wrapper&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.h:15:8,
    inlined from ‘condition_wrapper {anonymous}::insert_within_starlane_jumps_(const boost::python::tuple&, const boost::python::dict&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:644:85:
/usr/include/c++/14/bits/shared_ptr_base.h:1523:7: warning: ‘*(const std::__shared_ptr<const Condition::Condition, __gnu_cxx::_S_atomic>*)((char*)&<unnamed> + offsetof(boost::python::extract<condition_wrapper>,boost::python::extract<condition_wrapper>::<unnamed>.boost::python::converter::extract_rvalue<condition_wrapper>::m_data.boost::python::converter::rvalue_from_python_data<condition_wrapper>::<unnamed>.boost::python::converter::rvalue_from_python_storage<condition_wrapper>::storage)).std::__shared_ptr<const Condition::Condition, __gnu_cxx::_S_atomic>::_M_ptr’ may be used uninitialized [-Wmaybe-uninitialized]
 1523 |       __shared_ptr(const __shared_ptr&) noexcept = default;
      |       ^~~~~~~~~~~~
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp: In function ‘condition_wrapper {anonymous}::insert_within_starlane_jumps_(const boost::python::tuple&, const boost::python::dict&)’:
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:644:83: note: ‘<anonymous>’ declared here
  644 |         auto condition = boost::python::extract<condition_wrapper>(kw["condition"])();
      |                                                                                   ^
In copy constructor ‘std::__shared_count<_Lp>::__shared_count(const std::__shared_count<_Lp>&) [with __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’,
    inlined from ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(const std::__shared_ptr<_Tp, _Lp>&) [with _Tp = const Condition::Condition; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’ at /usr/include/c++/14/bits/shared_ptr_base.h:1523:7,
    inlined from ‘std::shared_ptr<_Tp>::shared_ptr(const std::shared_ptr<_Tp>&) [with _Tp = const Condition::Condition]’ at /usr/include/c++/14/bits/shared_ptr.h:203:7,
    inlined from ‘condition_wrapper::condition_wrapper(const condition_wrapper&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.h:15:8,
    inlined from ‘condition_wrapper {anonymous}::insert_within_starlane_jumps_(const boost::python::tuple&, const boost::python::dict&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:644:85:
/usr/include/c++/14/bits/shared_ptr_base.h:1073:19: warning: ‘((const std::__shared_count<__gnu_cxx::_S_atomic>*)((char*)&<unnamed> + offsetof(boost::python::extract<condition_wrapper>,boost::python::extract<condition_wrapper>::<unnamed>.boost::python::converter::extract_rvalue<condition_wrapper>::m_data.boost::python::converter::rvalue_from_python_data<condition_wrapper>::<unnamed>.boost::python::converter::rvalue_from_python_storage<condition_wrapper>::storage)))[1].std::__shared_count<>::_M_pi’ may be used uninitialized [-Wmaybe-uninitialized]
 1073 |       : _M_pi(__r._M_pi)
      |               ~~~~^~~~~
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp: In function ‘condition_wrapper {anonymous}::insert_within_starlane_jumps_(const boost::python::tuple&, const boost::python::dict&)’:
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:644:83: note: ‘<anonymous>’ declared here
  644 |         auto condition = boost::python::extract<condition_wrapper>(kw["condition"])();
      |                                                                                   ^
In copy constructor ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(const std::__shared_ptr<_Tp, _Lp>&) [with _Tp = const Condition::Condition; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’,
    inlined from ‘std::shared_ptr<_Tp>::shared_ptr(const std::shared_ptr<_Tp>&) [with _Tp = const Condition::Condition]’ at /usr/include/c++/14/bits/shared_ptr.h:203:7,
    inlined from ‘condition_wrapper::condition_wrapper(const condition_wrapper&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.h:15:8,
    inlined from ‘condition_wrapper {anonymous}::insert_within_distance_(const boost::python::tuple&, const boost::python::dict&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:659:85:
/usr/include/c++/14/bits/shared_ptr_base.h:1523:7: warning: ‘*(const std::__shared_ptr<const Condition::Condition, __gnu_cxx::_S_atomic>*)((char*)&<unnamed> + offsetof(boost::python::extract<condition_wrapper>,boost::python::extract<condition_wrapper>::<unnamed>.boost::python::converter::extract_rvalue<condition_wrapper>::m_data.boost::python::converter::rvalue_from_python_data<condition_wrapper>::<unnamed>.boost::python::converter::rvalue_from_python_storage<condition_wrapper>::storage)).std::__shared_ptr<const Condition::Condition, __gnu_cxx::_S_atomic>::_M_ptr’ may be used uninitialized [-Wmaybe-uninitialized]
 1523 |       __shared_ptr(const __shared_ptr&) noexcept = default;
      |       ^~~~~~~~~~~~
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp: In function ‘condition_wrapper {anonymous}::insert_within_distance_(const boost::python::tuple&, const boost::python::dict&)’:
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:659:83: note: ‘<anonymous>’ declared here
  659 |         auto condition = boost::python::extract<condition_wrapper>(kw["condition"])();
      |                                                                                   ^
In copy constructor ‘std::__shared_count<_Lp>::__shared_count(const std::__shared_count<_Lp>&) [with __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’,
    inlined from ‘std::__shared_ptr<_Tp, _Lp>::__shared_ptr(const std::__shared_ptr<_Tp, _Lp>&) [with _Tp = const Condition::Condition; __gnu_cxx::_Lock_policy _Lp = __gnu_cxx::_S_atomic]’ at /usr/include/c++/14/bits/shared_ptr_base.h:1523:7,
    inlined from ‘std::shared_ptr<_Tp>::shared_ptr(const std::shared_ptr<_Tp>&) [with _Tp = const Condition::Condition]’ at /usr/include/c++/14/bits/shared_ptr.h:203:7,
    inlined from ‘condition_wrapper::condition_wrapper(const condition_wrapper&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.h:15:8,
    inlined from ‘condition_wrapper {anonymous}::insert_within_distance_(const boost::python::tuple&, const boost::python::dict&)’ at /<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:659:85:
/usr/include/c++/14/bits/shared_ptr_base.h:1073:19: warning: ‘((const std::__shared_count<__gnu_cxx::_S_atomic>*)((char*)&<unnamed> + offsetof(boost::python::extract<condition_wrapper>,boost::python::extract<condition_wrapper>::<unnamed>.boost::python::converter::extract_rvalue<condition_wrapper>::m_data.boost::python::converter::rvalue_from_python_data<condition_wrapper>::<unnamed>.boost::python::converter::rvalue_from_python_storage<condition_wrapper>::storage)))[1].std::__shared_count<>::_M_pi’ may be used uninitialized [-Wmaybe-uninitialized]
 1073 |       : _M_pi(__r._M_pi)
      |               ~~~~^~~~~
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp: In function ‘condition_wrapper {anonymous}::insert_within_distance_(const boost::python::tuple&, const boost::python::dict&)’:
/<<PKGBUILDDIR>>/parse/ConditionPythonParser.cpp:659:83: note: ‘<anonymous>’ declared here
  659 |         auto condition = boost::python::extract<condition_wrapper>(kw["condition"])();
      |                                                                                   ^
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
[ 35%] Built target freeorionparseobj
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:159: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j2 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:18: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2