Bug#1075529: spacearyarya: ftbfs with GCC-14

[Matthias Klose]

Package: src:spacearyarya
Version: 1.0.3-1
Severity: important
Tags: sid trixie
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-14

[This bug is targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-14/g++-14, but succeeds to build with gcc-13/g++-13. The
severity of this report will be raised before the trixie release.

The full build log can be found at:
http://qa-logs.debian.net/2024/07/01/spacearyarya_1.0.3-1_unstable_gccexp.log
The last lines of the build log are at the end of this report.

To build with GCC 14, either set CC=gcc-14 CXX=g++-14 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-14/porting_to.html

[...]
ranking.c:44:18: warning: format ‘%u’ expects argument of type ‘unsigned int *’, but argument 3 has type ‘Uint32 *’ {aka ‘long unsigned int *’} [-Wformat=]
   44 |       fscanf(fp, "%"SCNu32" %"SCNu8" %s",
      |                  ^~~
   45 |              &(Ranking[i]->Score),
      |              ~~~~~~~~~~~~~~~~~~~~
      |              |
      |              Uint32 * {aka long unsigned int *}
/usr/include/inttypes.h:244:26: note: format string is defined here
  244 | # define SCNu32         "u"
ranking.c: In function ‘WriteScore’:
ranking.c:71:19: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘Uint32’ {aka ‘long unsigned int’} [-Wformat=]
   71 |     fprintf(fp, "%d\n", Root->HiScore);
      |                  ~^     ~~~~~~~~~~~~~
      |                   |         |
      |                   int       Uint32 {aka long unsigned int}
      |                  %ld
ranking.c:73:21: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘Uint32’ {aka ‘long unsigned int’} [-Wformat=]
   73 |       fprintf(fp, "%d %d %s\n",
      |                    ~^
      |                     |
      |                     int
      |                    %ld
   74 |               Ranking[i]->Score,
      |               ~~~~~~~~~~~~~~~~~
      |                         |
      |                         Uint32 {aka long unsigned int}
ranking.c: In function ‘ReadScore’:
ranking.c:42:5: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   42 |     fscanf(fp, "%"SCNu32, &(Root->HiScore));
      |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
ranking.c:44:7: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   44 |       fscanf(fp, "%"SCNu32" %"SCNu8" %s",
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   45 |              &(Ranking[i]->Score),
      |              ~~~~~~~~~~~~~~~~~~~~~
   46 |              &(Ranking[i]->Stage),
      |              ~~~~~~~~~~~~~~~~~~~~~
   47 |              Ranking[i]->Name);
      |              ~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:380: ranking.o] Error 1
make[2]: *** Waiting for unfinished jobs....
opening.c: In function ‘Opening’:
opening.c:79:35: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘Uint32’ {aka ‘long unsigned int’} [-Wformat=]
   79 |       sprintf(buff, "    %d    %08d     %d    %-8s", i + 1,
      |                                ~~~^
      |                                   |
      |                                   int
      |                                %08ld
   80 |               Ranking[i]->Score, Ranking[i]->Stage + 1,
      |               ~~~~~~~~~~~~~~~~~    
      |                         |
      |                         Uint32 {aka long unsigned int}
main.c: In function ‘main’:
main.c:184:27: error: passing argument 2 of ‘KXL_InitSound’ from incompatible pointer type [-Wincompatible-pointer-types]
  184 |   KXL_InitSound(WAV_PATH, sname);
      |                           ^~~~~
      |                           |
      |                           Uint8 ** {aka unsigned char **}
In file included from geki4.h:14,
                 from main.c:6:
/usr/include/KXL.h:304:52: note: expected ‘char **’ but argument is of type ‘Uint8 **’ {aka ‘unsigned char **’}
  304 | void        KXL_InitSound(const char *path, char **fname);
      |                                             ~~~~~~~^~~~~
make[2]: *** [Makefile:380: main.o] Error 1
make[2]: Leaving directory '/<<PKGBUILDDIR>>/src'
make[1]: *** [Makefile:348: all-recursive] Error 1
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:16: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2