Bug#1070022: libretro-beetle-psx FTBFS on mips64el with -Werror=implicit-function-declaration

[YunQiang Su]

On Sun, 28 Apr 2024 20:00:36 +0300 Adrian Bunk <bunk at debian.org> wrote:
> Source: libretro-beetle-psx
> Version: 0.9.38.6+git20151019-3
> Severity: serious
> Tags: ftbfs patch trixie sid
> 
> https://buildd.debian.org/status/fetch.php?pkg=libretro-beetle-psx&arch=mips64el&ver=0.9.38.6%2Bgit20151019-3%2Bb1&stamp=1714231581&raw=0
> 
> ...
> libretro-common/rthreads/rthreads.c: In function ‘scond_wait_timeout’:
> libretro-common/rthreads/rthreads.c:410:4: error: implicit declaration of function ‘gettimeofday’ [-Werror=implicit-function-declaration]
>   410 |    gettimeofday(&tm, NULL);
>       |    ^~~~~~~~~~~~
> cc1: some warnings being treated as errors
> make[2]: *** [Makefile:264: libretro-common/rthreads/rthreads.o] Error 1

I see there is some mips specific code in /rthreads.c

#elif defined(xxx__mips__)
   struct timeval tm;

   gettimeofday(&tm, NULL);
   now.tv_sec = tm.tv_sec;
   now.tv_nsec = tm.tv_usec * 1000;
#elif !defined(GEKKO)


I think that is not needed now. Let’s just remove it.

Otherwise, we should include <sys/time.h> since gettimeofday needs it.