Bug#1066054: spacearyarya FTBFS due to -Werror=implicit-function-declaration

[Helmut Grohne]

Source: spacearyarya
Version: 1.0.2-8
Severity: serious
Tags: ftbfs

Due to the time64 transition, -Werror=-implicit-function-declaration was
enabled in default build flags and this makes spacearyarya FTBFS: Please
include the time.h header.

| gcc -DPACKAGE_NAME=\"SpaceAryarya-KXL\" -DPACKAGE_TARNAME=\"spacearyarya-kxl\" -DPACKAGE_VERSION=\"1.0.2\" -DPACKAGE_STRING=\"SpaceAryarya-KXL\ 1.0.2\" -DPACKAGE_BUGREPORT=\"ml at kxl.hn.or\" -DPACKAGE_URL=\"\" -DPACKAGE=\"spacearyarya-kxl\" -DVERSION=\"1.0.2\" -DHAVE_LIBKXL=1 -DHAVE_LIBKXL=1 -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_UNISTD_H=1 -DDATA_PATH=\"/usr/share/games/spacearyarya/data\" -DBMP_PATH=\"/usr/share/games/spacearyarya/bmp\" -DWAV_PATH=\"/usr/share/games/spacearyarya/wav\" -DTITLE=\"spacearyarya-kxl\ 1.0.2\" -I.   -Wdate-time -D_FORTIFY_SOURCE=2  -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/<<PKGBUILDDIR>>=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -c -o main.o main.c
| main.c: In function ‘options’:
| main.c:144:10: error: implicit declaration of function ‘strcmp’ [-Werror=implicit-function-declaration]
|   144 |     if (!strcmp(argv[i], "-h") || !strcmp(argv[i], "--help")) {
|       |          ^~~~~~
| main.c:7:1: note: include ‘<string.h>’ or provide a declaration of ‘strcmp’
|     6 | #include "extern.h"
|   +++ |+#include <string.h>
|     7 | 
| main.c: In function ‘main’:
| main.c:179:9: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]
|   179 |   srand(time(NULL));
|       |         ^~~~
| main.c:7:1: note: ‘time’ is defined in header ‘<time.h>’; did you forget to ‘#include <time.h>’?
|     6 | #include "extern.h"
|   +++ |+#include <time.h>
|     7 | 
| misc.c: In function ‘ClearAndGameOver’:
| misc.c:107:5: error: implicit declaration of function ‘ScoreRanking’ [-Werror=implicit-function-declaration]
|   107 |     ScoreRanking();
|       |     ^~~~~~~~~~~~
| ranking.c: In function ‘ReadScore’:
| ranking.c:41:5: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
|    41 |     fscanf(fp, "%"SCNu32, &(Root->HiScore));
|       |     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ranking.c:43:7: warning: ignoring return value of ‘fscanf’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
|    43 |       fscanf(fp, "%"SCNu32" %"SCNu8" %s",
|       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|    44 |              &(Ranking[i]->Score),
|       |              ~~~~~~~~~~~~~~~~~~~~~
|    45 |              &(Ranking[i]->Stage),
|       |              ~~~~~~~~~~~~~~~~~~~~~
|    46 |              Ranking[i]->Name);
|       |              ~~~~~~~~~~~~~~~~~

Helmut