Bug#1066305: 3dchess: FTBFS: init.c:140:21: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]

[Lucas Nussbaum]

Source: 3dchess
Version: 0.8.1-21
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas at debian.org
Usertags: ftbfs-20240313 ftbfs-trixie ftbfs-impfuncdef

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.

This is most likely caused by a change in dpkg 1.22.6, that enabled
-Werror=implicit-function-declaration. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

Relevant part (hopefully):
> gcc `dpkg-buildflags --get CFLAGS` -O2 -fstrength-reduce -fpcc-struct-return -DVERSION=\"0.8.1\"  -DHAVE_UNISTD_H -DHAVE_ULIMIT_H -DUNDO_ANY_MOVE -I../include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o xnet.o xnet.c
> engine.c: In function ‘TraverseDir’:
> engine.c:82:43: warning: conversion from ‘unsigned int’ to ‘unsigned char:2’ changes value from ‘4294967295’ to ‘3’ [-Woverflow]
>    82 |           SQUARE_INVALID->xyzPos.zLevel = UINT_MAX;
>       |                                           ^~~~~~~~
> init.c: In function ‘Init3Dc’:
> init.c:140:21: error: implicit declaration of function ‘time’ [-Werror=implicit-function-declaration]
>   140 |   srandom((unsigned)time(NULL));
>       |                     ^~~~
> init.c:34:1: note: ‘time’ is defined in header ‘<time.h>’; did you forget to ‘#include <time.h>’?
>    33 | #include "../include/3Dc.h"
>   +++ |+#include <time.h>
>    34 | 
> gcc `dpkg-buildflags --get CFLAGS` -O2 -fstrength-reduce -fpcc-struct-return -DVERSION=\"0.8.1\"  -DHAVE_UNISTD_H -DHAVE_ULIMIT_H -DUNDO_ANY_MOVE -I../include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o callbaks.o callbaks.c
> gcc `dpkg-buildflags --get CFLAGS` -O2 -fstrength-reduce -fpcc-struct-return -DVERSION=\"0.8.1\"  -DHAVE_UNISTD_H -DHAVE_ULIMIT_H -DUNDO_ANY_MOVE -I../include -Wdate-time -D_FORTIFY_SOURCE=2  -c -o DrawingA.o DrawingA.c
> cc1: some warnings being treated as errors
> make[1]: *** [<builtin>: init.o] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/03/13/3dchess_0.8.1-21_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240313;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240313&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.