Bug#1066953: pvpgn: FTBFS with -Werror=implicit-function-declaration

[Andreas Beckmann]

Source: pvpgn
Version: 1.8.5-3
Severity: serious
Tags: ftbfs sid trixie
Justification: fails to build from source (but built successfully in the past)

Hi,

pvpgn FTBFS with -Werror=implicit-function-declaration which was
recently enabled by default in dpkg 1.22.6 to support the 64-bit time_t
transition. For more information, see
https://wiki.debian.org/qa.debian.org/FTBFS#A2024-03-13_-Werror.3Dimplicit-function-declaration

gcc -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/build/pvpgn-1.8.5=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection   -DHAVE_CONFIG_H   -DWITH_SQL_MYSQL -DWITH_SQL_PGSQL -DWITH_SQL_SQLITE
3 -DBNETD_DEFAULT_CONF_FILE=\"/etc/pvpgn/bnetd.conf\" -DD2CS_DEFAULT_CONF_FILE=\"/etc/pvpgn/d2cs.conf\" -DD2DBS_DEFAULT_CONF_FILE=\"/etc/pvpgn/d2dbs.conf\" -I"." -Wdate-time -D_FORTIFY_SOURCE=2  -I/usr/include/mysql -I/usr/include/postgresql -I/usr/include -
fno-strict-aliasing -c bnetd/handle_irc.c -o bnetd/handle_irc.o
bnetd/handle_irc.c: In function '_handle_whereto_command':
bnetd/handle_irc.c:1391:8: error: implicit declaration of function 'trans_net' [-Werror=implicit-function-declaration]
 1391 |        trans_net(conn_get_addr(conn), &addr, &port);
      |        ^~~~~~~~~
bnetd/handle_irc.c: In function '_handle_join_command.part.0.isra':
bnetd/handle_irc.c:1026:75: warning: '%s' directive writing up to 508 bytes into a region of size between 2 and 510 [-Wformat-overflow=]
 1026 |                                                         sprintf(temp,"%s :%s",ircname,topic);
      |                                                                           ^~
In file included from /usr/include/stdio.h:906,
                 from ./common/util.h:26,
                 from bnetd/handle_irc.c:23:
In function 'sprintf',
    inlined from '_handle_join_command.part.0.isra' at bnetd/handle_irc.c:1026:8:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: '__builtin___sprintf_chk' output between 3 and 1019 bytes into a destination of size 512
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
Dependency check: bniutils
bnetd/handle_irc.c: In function '_handle_joingame_command':
bnetd/handle_irc.c:1683:75: warning: '%s' directive writing up to 508 bytes into a region of size between 2 and 510 [-Wformat-overflow=]
 1683 |                                                         sprintf(temp,"%s :%s",ircname,topic);
      |                                                                           ^~
In function 'sprintf',
    inlined from '_handle_joingame_command' at bnetd/handle_irc.c:1683:8:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: '__builtin___sprintf_chk' output between 3 and 1019 bytes into a destination of size 512
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[1]: *** [Makefile:740: bnetd/handle_irc.o] Error 1


Andreas