Bug#1087144: dolphin-emu: misrepresents copyright of vendored fatfs, fails to conform to licence terms

[наб]

Source: dolphin-emu
Version: 2407+dfsg-1
Severity: serious
Justification: makes package illegal, policy 4.5, policy 2.3

Dear Maintainer,

dolphin-emu embeds fatfs, and fatfs makes it into the binary.
The licence stipulates
/ 1. Redistributions of source code must retain the above copyright notice,
/    this condition and the following disclaimer.

Whereas d/copyright indicates
  Files: *
  Copyright: 2003-2024, Dolphin Emulator Project
  License: GPL-2+

Thus, the terms of the licence are not met.
The same follows trivially for policy 4.5 and 2.3.

Feel free to take inspiration from swupdate-2024.05.2+dfsg:
-- >8 --
Files:     fs/diskio.h
           fs/ff*
Copyright: 2019, ChaN, all right reserved.
License:   BSD-1-Clause-FatFs

License: BSD-1-Clause-FatFs
 FatFs module is an open source software. Redistribution and use of FatFs in
 source and binary forms, with or without modification, are permitted provided
 that the following condition is met:
 .
 1. Redistributions of source code must retain the above copyright notice,
    this condition and the following disclaimer.
 .
 This software is provided by the copyright holder and contributors "AS IS"
 and any warranties related to this software are DISCLAIMED.
 The copyright owner or contributors be NOT LIABLE for any damages caused
 by use of this software.
-- >8 --

Feel free to take inspiration from tinyusb-0.16.0+dfsg:
-- >8 --
Files: lib/fatfs/*
Copyright: 2019 - 2022, ChaN
License: fatfs-custom

License: fatfs-custom
 FatFs has being developped as a personal project of the author, ChaN. It is
 free from the code anyone else wrote at current release. Following code block
 shows a copy of the FatFs license document that heading the source files.
 .
 /*----------------------------------------------------------------------------/
 /  FatFs - Generic FAT Filesystem Module  Rx.xx                               /
 /-----------------------------------------------------------------------------/
 /
 / Copyright (C) 20xx, ChaN, all right reserved.
 /
 / FatFs module is an open source software. Redistribution and use of FatFs in
 / source and binary forms, with or without modification, are permitted provided
 / that the following condition is met:
 /
 / 1. Redistributions of source code must retain the above copyright notice,
 /    this condition and the following disclaimer.
 /
 / This software is provided by the copyright holder and contributors "AS IS"
 / and any warranties related to this software are DISCLAIMED.
 / The copyright owner or contributors be NOT LIABLE for any damages caused
 / by use of this software.
 /----------------------------------------------------------------------------*/
 .
 Therefore FatFs license is one of the BSD-style licenses, but there is a
 significant feature. FatFs is mainly intended for embedded systems. In order to
 extend the usability for commercial products, the redistributions of FatFs in
 binary form, such as embedded code, binary library and any forms without source
 code, do not need to include about FatFs in the documentations. This is
 equivalent to the 1-clause BSD license. Of course FatFs is compatible with the
 most of open source software licenses include GNU GPL. When you redistribute
 the FatFs source code with changes or create a fork, the license can also be
 changed to GNU GPL, BSD-style license or any open source software license that
 not conflict with FatFs license.
-- >8 --

-- System Information:
Debian Release: 12.4
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'stable-security'), (500, 'stable-debug'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-12-amd64 (SMP w/24 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_FIRMWARE_WORKAROUND, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-games-devel/attachments/20241109/cecec1bb/attachment.sig>