Bug#1075234: lordsawar: ftbfs with GCC-14

[Patrice Duroux]

Source: lordsawar
Version: 0.3.2+frogknows-1
Followup-For: Bug #1075234

Hi,

Here is a suggestion to solve this issue.
It also includes some other minor packaging updates:
- change 2 http to 2 https,
- replace lintian complaining gnome-common by intltool,
- bump SV from 4.5.0 to 4.7.0
- add R3: no.

Best regards,
Patrice


-- System Information:
Debian Release: trixie/sid
  APT prefers unstable-debug
  APT policy: (500, 'unstable-debug'), (500, 'unstable'), (1, 'experimental-debug'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.12-rc6-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
-------------- next part --------------
diff --git a/debian/control b/debian/control
index a7a42dc..c46e8fc 100644
--- a/debian/control
+++ b/debian/control
@@ -7,15 +7,16 @@ Uploaders:
  Markus Koschany <apo at debian.org>
 Build-Depends:
  debhelper-compat (= 13),
- gnome-common,
+ intltool,
  libarchive-dev,
  libgstreamermm-1.0-dev,
  libgtkmm-3.0-dev,
  libsigc++-2.0-dev,
  libxml++2.6-dev,
  libxslt1-dev
-Standards-Version: 4.5.0
-Homepage: http://www.nongnu.org/lordsawar/
+Standards-Version: 4.7.0
+Rules-Requires-Root: no
+Homepage: https://www.nongnu.org/lordsawar/
 Vcs-Git: https://salsa.debian.org/games-team/lordsawar.git
 Vcs-Browser: https://salsa.debian.org/games-team/lordsawar
 
diff --git a/debian/copyright b/debian/copyright
index b04db68..e8d8cca 100644
--- a/debian/copyright
+++ b/debian/copyright
@@ -1,6 +1,6 @@
 Format: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/
 Upstream-Name: LordsAWar
-Source: http://download-mirror.savannah.gnu.org/releases/lordsawar/
+Source: https://download-mirror.savannah.gnu.org/releases/lordsawar/
 
 Files: *
 Copyright:
diff --git a/debian/patches/g++14.patch b/debian/patches/g++14.patch
new file mode 100644
index 0000000..2a15c24
--- /dev/null
+++ b/debian/patches/g++14.patch
@@ -0,0 +1,21 @@
+Subject: constructor with invalid initializer for array member
+Origin: https://cgit.freebsd.org/ports/tree/games/lordsawar/files/patch-src_armyproto.cpp?id=4bd06230f8a700558218a99ec776e368b61c5d1d
+
+--- a/src/armyproto.cpp
++++ b/src/armyproto.cpp
+@@ -35,9 +35,14 @@
+ 
+ ArmyProto::ArmyProto(const ArmyProto& a)
+     :ArmyProtoBase(a), d_id(a.d_id), d_defends_ruins(a.d_defends_ruins), 
+-     d_awardable(a.d_awardable), d_image_name(a.d_image_name),
++     d_awardable(a.d_awardable),
+      d_gender(a.d_gender)
+ {
++  for (size_t i = 0; i < sizeof(d_image_name)/sizeof(d_image_name[0]); i++)
++    {
++      d_image_name[i] = a.d_image_name[i];
++    }
++
+   for (unsigned int c = Shield::WHITE; c <= Shield::NEUTRAL; c++)
+     {
+       d_image_name[c] = a.d_image_name[c];
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..03481f4
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+g++14.patch