Bug#1082679: freedoom: FTBFS with .dsc from archive: mis-detects that deutex does not support PNG

[Santiago Vila]

Hi. To test, I simplified the line in the Makefile to this:

deutex -h | grep -qw PNG

This should have the same effect but without the explanatory error message,
i.e. if it fails, make will stop.

The build log for a failed build looks like this:

deutex -h | grep -qw PNG
make -C lumps/dehacked # graphics/text depends on generated dehacked files
make[3]: Entering directory '/<<PKGBUILDDIR>>/lumps/dehacked'
../../scripts/simplecpp -DFREEDM < dehacked.txt > ../fdm_deh.lmp
make[2]: *** [Makefile:56: deutex-check] Error 141
make[2]: *** Waiting for unfinished jobs....

I searched for error 141 and found this:

https://stackoverflow.com/questions/19120263/why-exit-code-141-with-grep-q

So, the error in freedoom seems to happen because of two things:

a) using grep -q
b) The SHELL="bash -Eeuo pipefail" definition in debian/rules.

I don't know what would be the best way to fix this.

Maybe we could just take for granted that deutex has PNG support,
because it has, and drop the check in the toplevel Makefile,
as in the attached patch.

(I withdraw my suggestion to use --no-parallel).

Thanks.
-------------- next part --------------
--- a/Makefile
+++ b/Makefile
@@ -53,13 +53,6 @@ lumps/freedoom.lmp lumps/freedm.lmp: force
 
 # Make sure deutex supports PNG
 deutex-check:
-	@$(DEUTEX) -h | grep -qw PNG || { \
-	echo "$(DEUTEX) does not support PNG. Try building deutex with the PNG"; \
-	echo "libraries (libpng and libpng-devel or similar packages) installed."; \
-	echo "deutex can be downloaded from https://github.com/Doom-Utils/deutex."; \
-	echo "The full path to duetex can be specified by passing"; \
-	echo "DEUTEX=/the/path/to/deutex to make when building Freedoom."; \
-	exit 1; }
 
 # Make sure that no PNG files are modified if scripts are to modify them.
 pngs-modified-check: