Bug#1091286: xsok: FTBFS on armhf: showscore.c:75:15: error: passing argument 1 of ‘ctime’ from incompatible pointer type [-Wincompatible-pointer-types]

[Alexandre Detiste]

Hi Patrice et Petter

About:

--- a/src/showscore.c
+++ b/src/showscore.c
@@ -72,7 +72,7 @@
 filename = strrchr(filename, '/') + 1;
     ReadHighscores(filename);
-    z = ctime(&p[4]);
+    z = ctime((const time_t *) &p[4]);
     if (strchr(z, '\n'))

We can't stuff 64 bits into a 32 bit variable.

But I searched in the game and thereis _nowhere_
in the game the possibility to read the highscore.

This job is delegated to a CLI that is built
but was never shipped within the .deb

I did this one-line fix for now ("ALLTARGETS")
but a long time fix would be to remove
all support for score altogether.

(for now we ony have a blob of hexadecimal data
nobody can read without building from source)

Greetings and thanks for reviewing this



--- a/src/Imakefile
+++ b/src/Imakefile
@@ -100,7 +100,7 @@

OBJS = $(STDOBJS) $(XOBJS) $(KIT_OBJS)
MYPROG = xsok
-ALLTARGETS = username combine showscore mergescores $(MYPROG)
+ALLTARGETS = combine username $(MYPROG)
DEFINES = $(HELP_OPTION) $(SOUND_OPTION) $(XPMINCLUDE) $(NET_DEFINE) \
   $(PIPE_DEFINE) -DXSOKDIR=\"$(XSOKLIBDIR)\" -DXSOKSAVE=\"$(XSOKSAVEDIR)\" \
   $(SLEEP_DEFINE) -DDEBIAN