Bug#1123893: endless-sky: FTBFS with libsdl2-dev from src:sdl2-compat: integration tests fail

[Simon McVittie]

Source: endless-sky
Version: 0.10.16-2
Severity: normal
Tags: ftbfs forky sid moreinfo

sdl2-compat is a reimplementation of the SDL 2 API using SDL 3. 
It can be tested by installing the libsdl2-compat-shim and 
libsdl2-compat-dev packages from testing/unstable, or by installing the 
libsdl2-2.0-0 and libsdl2-dev packages built by src:sdl2-compat in 
experimental.

After discussion with SDL upstream, I'm looking into what needs to 
happen for Debian (and indirectly Ubuntu) to replace "classic" SDL2 
(src:libsdl2) with sdl2-compat, following in the footsteps of other 
distros like Arch and Fedora that have already done this transition.

During a mass-rebuild on debusine.debian.net, endless-sky failed to 
build from source with libsdl2-dev provided by src:sdl2-compat, showing 
integration test failures. I can reproduce this in a local build:

>Test project /build/reproducible-path/endless-sky-0.10.16/obj-x86_64-linux-gnu
>      Start  1: Abort Take Off On Excess Outfits In Cargo Warning
> 1/45 Test  #1: Abort Take Off On Excess Outfits In Cargo Warning ...***Failed    0.72 sec
>      Start  3: Afterburner-flight - Simple depart land
> 2/45 Test  #3: Afterburner-flight - Simple depart land .............***Failed    0.79 sec
>      Start  5: Atrocity Test - New Atrocity
> 3/45 Test  #5: Atrocity Test - New Atrocity ........................***Failed    0.84 sec
>      Start  7: Capture Uncapturable With Capturable Override
> 4/45 Test  #7: Capture Uncapturable With Capturable Override .......***Failed    0.83 sec
>      Start  9: Checking For A Gifted Ship
> 5/45 Test  #9: Checking For A Gifted Ship ..........................***Failed    0.82 sec
>      Start 11: Clear flagship model condition
> 6/45 Test #11: Clear flagship model condition ......................***Failed    0.80 sec
>      Start 13: Conditional Test
> 7/45 Test #13: Conditional Test ....................................***Failed    0.81 sec
>      Start 15: Conditional Test Goto
> 8/45 Test #15: Conditional Test Goto ...............................***Failed    0.80 sec
>      Start 17: Conditional Test Out of Bound
> 9/45 Test #17: Conditional Test Out of Bound .......................***Failed    0.83 sec
>      Start 19: Ember Wastes Navigation
>10/45 Test #19: Ember Wastes Navigation .............................***Failed    0.83 sec
>      Start 21: Enter Name in Conversation
>11/45 Test #21: Enter Name in Conversation ..........................***Failed    0.87 sec
>      Start 23: Flagship Attribute Autoconditions
>12/45 Test #23: Flagship Attribute Autoconditions ...................***Failed    0.81 sec
>      Start 25: Flagship Planet Attribute Test
>13/45 Test #25: Flagship Planet Attribute Test ......................***Failed    0.85 sec
>      Start 27: Hyperjumps To Autocondition
>14/45 Test #27: Hyperjumps To Autocondition .........................***Failed    0.86 sec
>      Start 29: Illegal Test - Ignore and New Illegal
>15/45 Test #29: Illegal Test - Ignore and New Illegal ...............***Failed    0.89 sec
>      Start 31: Job Board During Mission Test
>16/45 Test #31: Job Board During Mission Test .......................***Failed    0.84 sec
>      Start 33: Job Board Mission From Map Test
>17/45 Test #33: Job Board Mission From Map Test .....................***Failed    0.80 sec
>      Start 35: Job Board Mission From Planet Test
>18/45 Test #35: Job Board Mission From Planet Test ..................***Failed    0.82 sec
>      Start 37: Landing in a system with multiple planets
>19/45 Test #37: Landing in a system with multiple planets ...........***Failed    0.80 sec
>      Start 39: Loading and Reloading
>20/45 Test #39: Loading and Reloading ...............................***Failed    0.81 sec
>      Start 41: Loading and Saving
>21/45 Test #41: Loading and Saving ..................................***Failed    0.84 sec
>      Start 43: Outfitter Mission Test
>22/45 Test #43: Outfitter Mission Test ..............................***Failed    0.86 sec
>      Start 45: Plugin Installed Autocondition
>23/45 Test #45: Plugin Installed Autocondition ......................***Failed    0.84 sec
>      Start 47: Save To Default Snapshot
>24/45 Test #47: Save To Default Snapshot ............................***Failed    0.80 sec
>      Start 49: Saving during conversation
>25/45 Test #49: Saving during conversation ..........................***Failed    0.81 sec
>      Start 51: Sell 0 ships
>26/45 Test #51: Sell 0 ships ........................................***Failed    0.85 sec
>      Start 53: Sell 1 ship
>27/45 Test #53: Sell 1 ship .........................................***Failed    0.92 sec
>      Start 55: Sell 2 ships
>28/45 Test #55: Sell 2 ships ........................................***Failed    0.82 sec
>      Start 57: Sell 3 ships
>29/45 Test #57: Sell 3 ships ........................................***Failed    0.88 sec
>      Start 59: Sell Outfit On Take Off
>30/45 Test #59: Sell Outfit On Take Off .............................***Failed    0.89 sec
>      Start 61: Shipyard Mission Test
>31/45 Test #61: Shipyard Mission Test ...............................***Failed    0.85 sec
>      Start 63: Store Outfit On Take Off
>32/45 Test #63: Store Outfit On Take Off ............................***Failed    0.85 sec
>      Start 65: Taking Ship With Outfits And Unconstrained
>33/45 Test #65: Taking Ship With Outfits And Unconstrained ..........***Failed    0.82 sec
>      Start 67: Test-Framework - Calling other functions
>34/45 Test #67: Test-Framework - Calling other functions ............***Failed    0.83 sec
>      Start 69: Test-Framework - Conditions Arithmetic and Loops
>35/45 Test #69: Test-Framework - Conditions Arithmetic and Loops ....***Failed    0.91 sec
>      Start 71: Test-Framework - Empty Test Sequence
>36/45 Test #71: Test-Framework - Empty Test Sequence ................***Failed    0.95 sec
>      Start 73: Test-Framework - Empty Testcase
>37/45 Test #73: Test-Framework - Empty Testcase .....................***Failed    0.88 sec
>      Start 75: Test-Framework - Load Depart Land
>38/45 Test #75: Test-Framework - Load Depart Land ...................***Failed    0.83 sec
>      Start 77: Test-Framework - Mission Injection
>39/45 Test #77: Test-Framework - Mission Injection ..................***Failed    0.82 sec
>      Start 79: Test-Framework - Navigate
>40/45 Test #79: Test-Framework - Navigate ...........................***Failed    0.86 sec
>      Start 81: Test-Framework - Recursive Calling
>41/45 Test #81: Test-Framework - Recursive Calling ..................***Failed    0.82 sec
>      Start 83: Test-Framework - UI Keyboard controls
>42/45 Test #83: Test-Framework - UI Keyboard controls ...............***Failed    0.82 sec
>      Start 85: To Accept Blocks Accepts When Conditions Fail
>43/45 Test #85: To Accept Blocks Accepts When Conditions Fail .......***Failed    0.83 sec
>      Start 87: Wormhole Navigation
>44/45 Test #87: Wormhole Navigation .................................***Failed    0.80 sec
>      Start 89: unit
>45/45 Test #89: unit ................................................   Passed    0.13 sec

Unfortunately, detailed test output is not included in the build log, so 
I can't see what is going wrong here. I'll report that as a separate 
bug, since it makes debugging harder and is contrary to Policy §4.9.

One possible root cause is that this might be relying on the offscreen 
renderer being available by default, which was true in "classic" SDL2 
but is no longer true in sdl2-compat (see #1123731 in src:wesnoth-1.18). 
But it's hard to tell until I've seen a detailed log, and I have limited 
network/computation locally at the moment.

    smcv