Bug#1096537: dopewars: ftbfs with GCC-15

[Matthias Klose]

Package: src:dopewars
Version: 1.6.2-1
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/dopewars_1.6.2-1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
gtk_client.c:137:13: note: ‘TalkToPlayers’ declared here
  137 | static void TalkToPlayers(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~~~~~
gtk_client.c:172:35: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  172 |   {N_("/List/_Players..."), NULL, ListPlayers, 0, NULL},
      |                                   ^~~~~~~~~~~
gtk_client.c:172:35: note: (near initialization for ‘menu_items[10].callback’)
gtk_client.c:135:13: note: ‘ListPlayers’ declared here
  135 | static void ListPlayers(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~~~
gtk_client.c:173:34: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  173 |   {N_("/List/_Scores..."), NULL, ListScores, 0, NULL},
      |                                  ^~~~~~~~~~
gtk_client.c:173:34: note: (near initialization for ‘menu_items[11].callback’)
gtk_client.c:101:13: note: ‘ListScores’ declared here
  101 | static void ListScores(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~~
gtk_client.c:174:37: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  174 |   {N_("/List/_Inventory..."), NULL, ListInventory, 0, NULL},
      |                                     ^~~~~~~~~~~~~
gtk_client.c:174:37: note: (near initialization for ‘menu_items[12].callback’)
gtk_client.c:102:13: note: ‘ListInventory’ declared here
  102 | static void ListInventory(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~~~~~
gtk_client.c:176:34: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  176 |   {N_("/Errands/_Spy..."), NULL, SpyOnPlayer, 0, NULL},
      |                                  ^~~~~~~~~~~
gtk_client.c:176:34: note: (near initialization for ‘menu_items[14].callback’)
gtk_client.c:142:13: note: ‘SpyOnPlayer’ declared here
  142 | static void SpyOnPlayer(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~~~
gtk_client.c:177:37: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  177 |   {N_("/Errands/_Tipoff..."), NULL, TipOff, 0, NULL},
      |                                     ^~~~~~
gtk_client.c:177:37: note: (near initialization for ‘menu_items[15].callback’)
gtk_client.c:141:13: note: ‘TipOff’ declared here
  141 | static void TipOff(GtkWidget *widget, gpointer data);
      |             ^~~~~~
gtk_client.c:180:37: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  180 |   {"/Errands/S_ack Bitch...", NULL, SackBitch, 0, NULL},
      |                                     ^~~~~~~~~
gtk_client.c:180:37: note: (near initialization for ‘menu_items[16].callback’)
gtk_client.c:144:13: note: ‘SackBitch’ declared here
  144 | static void SackBitch(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~
gtk_client.c:181:46: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  181 |   {N_("/Errands/_Get spy reports..."), NULL, GetSpyReports, 0, NULL},
      |                                              ^~~~~~~~~~~~~
gtk_client.c:181:46: note: (near initialization for ‘menu_items[17].callback’)
gtk_client.c:157:13: note: ‘GetSpyReports’ declared here
  157 | static void GetSpyReports(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~~~~~
gtk_client.c:183:33: error: initialization of ‘void (*)(void)’ from incompatible pointer type ‘void (*)(GtkWidget *, void *)’ {aka ‘void (*)(struct _GtkWidget *, void *)’} [-Wincompatible-pointer-types]
  183 |   {N_("/Help/_About..."), "F1", display_intro, 0, NULL}
      |                                 ^~~~~~~~~~~~~
gtk_client.c:183:33: note: (near initialization for ‘menu_items[19].callback’)
gtk_client.c:95:13: note: ‘display_intro’ declared here
   95 | static void display_intro(GtkWidget *widget, gpointer data);
      |             ^~~~~~~~~~~~~
make[4]: *** [Makefile:444: gtk_client.o] Error 1
make[4]: Leaving directory '/build/reproducible-path/dopewars-1.6.2/src/gui_client'
make[3]: *** [Makefile:655: all-recursive] Error 1
make[3]: Leaving directory '/build/reproducible-path/dopewars-1.6.2/src'
make[2]: *** [Makefile:475: all] Error 2
make[2]: Leaving directory '/build/reproducible-path/dopewars-1.6.2/src'
make[1]: *** [Makefile:480: all-recursive] Error 1
make[1]: Leaving directory '/build/reproducible-path/dopewars-1.6.2'
dh_auto_build: error: make -j1 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2