Bug#1096656: freesweep: ftbfs with GCC-15

[Matthias Klose]

Package: src:freesweep
Version: 1.0.2-2
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/freesweep_1.0.2-2_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
sweep.h:66:9: warning: ‘USE_GROUP_BEST_FILE’ redefined
   66 | #define USE_GROUP_BEST_FILE
      |         ^~~~~~~~~~~~~~~~~~~
In file included from sweep.h:8:
config.h:26:9: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      |         ^~~~~~~~~~~~~~~~~~~
fgui.c: In function ‘Display’:
fgui.c:313:17: warning: this ‘while’ clause does not guard... [-Wmisleading-indentation]
  313 |                 while(*p != '/') p--; p++; /* there will always be a / in it */
      |                 ^~~~~
fgui.c:313:39: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘while’
  313 |                 while(*p != '/') p--; p++; /* there will always be a / in it */
      |                                       ^
fgui.c: In function ‘CreateFileBuf’:
fgui.c:41:9: warning: ignoring return value of ‘chdir’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
   41 |         chdir(dir);
      |         ^~~~~~~~~~
In file included from files.c:11:
sweep.h:66:9: warning: ‘USE_GROUP_BEST_FILE’ redefined
   66 | #define USE_GROUP_BEST_FILE
      |         ^~~~~~~~~~~~~~~~~~~
In file included from drawing.c:11:
sweep.h:66:9: warning: ‘USE_GROUP_BEST_FILE’ redefined
   66 | #define USE_GROUP_BEST_FILE
      |         ^~~~~~~~~~~~~~~~~~~
In file included from sweep.h:8:
config.h:26:9: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      |         ^~~~~~~~~~~~~~~~~~~
In file included from sweep.h:8:
config.h:26:9: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      |         ^~~~~~~~~~~~~~~~~~~
In file included from error.c:11:
sweep.h:66:9: warning: ‘USE_GROUP_BEST_FILE’ redefined
   66 | #define USE_GROUP_BEST_FILE
      |         ^~~~~~~~~~~~~~~~~~~
In file included from game.c:11:
sweep.h:66:9: warning: ‘USE_GROUP_BEST_FILE’ redefined
   66 | #define USE_GROUP_BEST_FILE
      |         ^~~~~~~~~~~~~~~~~~~
In file included from sweep.h:8:
config.h:26:9: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      |         ^~~~~~~~~~~~~~~~~~~
In file included from sweep.h:8:
config.h:26:9: note: this is the location of the previous definition
   26 | #define USE_GROUP_BEST_FILE 1
      |         ^~~~~~~~~~~~~~~~~~~
game.c: In function ‘ParseArgs’:
game.c:417:17: error: too many arguments to function ‘PrintGPL’; expected 0, have 1
  417 |                 PrintGPL(NULL);
      |                 ^~~~~~~~ ~~~~
sweep.h:358:6: note: declared here
  358 | void PrintGPL();
      |      ^~~~~~~~
game.c: In function ‘ReReadyGame’:
game.c:481:58: warning: variable ‘HViewable’ set but not used [-Wunused-but-set-variable]
  481 |         int MinesToSet=0, RandX=0, RandY=0, VViewable=0, HViewable=0;
      |                                                          ^~~~~~~~~
game.c:481:45: warning: variable ‘VViewable’ set but not used [-Wunused-but-set-variable]
  481 |         int MinesToSet=0, RandX=0, RandY=0, VViewable=0, HViewable=0;
      |                                             ^~~~~~~~~
make[1]: *** [Makefile:41: game.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/build/reproducible-path/freesweep-1.0.2'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:7: build] Error 25
dpkg-buildpackage: error: debian/rules build subprocess returned exit status 2