Bug#1097090: koules: ftbfs with GCC-15

[Matthias Klose]

Package: src:koules
Version: 1.4-28
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/koules_1.4-28_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |                                   ~~~~~~~~~~~~~~~~~
gcc -g -O2 -fno-strict-aliasing    -Ixlib     -Dlinux -D__amd64__ -D_POSIX_C_SOURCE=199309L 				-D_POSIX_SOURCE -D_XOPEN_SOURCE 				-D_BSD_SOURCE -D_SVID_SOURCE                                 -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 				  				  -DFUNCPROTO=15 -DNARROWPROTO   -DONLYANSI -DSOUND -DJOYSTICK -DNETSUPPORT -DMITSHM -DHAVEUSLEEP -Wall -fomit-frame-pointer -O6  -ffast-math  -Ixlib	 -DASSEMBLY	-DSOUNDSERVER=\"/usr/lib/games/koules/koules.sndsrv.linux\" 	-DSOUNDDIR=\"/usr/lib/games/koules\" 	-DSOUNDDEV=\"/dev/dsp\"  -Wdate-time -D_FORTIFY_SOURCE=2  -c -o koules.sndsrv.linux.o koules.sndsrv.linux.c
In file included from /usr/include/x86_64-linux-gnu/bits/libc-header-start.h:33,
                 from /usr/include/stdio.h:28,
                 from koules.sndsrv.linux.c:12:
/usr/include/features.h:197:3: warning: #warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE" [-Wcpp]
  197 | # warning "_BSD_SOURCE and _SVID_SOURCE are deprecated, use _DEFAULT_SOURCE"
      |   ^~~~~~~
koules.sndsrv.linux.c: In function ‘init’:
koules.sndsrv.linux.c:77:20: error: passing argument 2 of ‘signal’ from incompatible pointer type [-Wincompatible-pointer-types]
   77 |   signal (SIGTERM, quit);       /* Setup Terminate Signal Handler */
      |                    ^~~~
      |                    |
      |                    void (*)(void)
In file included from koules.sndsrv.linux.c:20:
/usr/include/signal.h:88:57: note: expected ‘__sighandler_t’ {aka ‘void (*)(int)’} but argument is of type ‘void (*)(void)’
   88 | extern __sighandler_t signal (int __sig, __sighandler_t __handler)
      |                                          ~~~~~~~~~~~~~~~^~~~~~~~~
koules.sndsrv.linux.c:46:1: note: ‘quit’ declared here
   46 | quit ()
      | ^~~~
/usr/include/signal.h:72:16: note: ‘__sighandler_t’ declared here
   72 | typedef void (*__sighandler_t) (int);
      |                ^~~~~~~~~~~~~~
koules.sndsrv.linux.c: In function ‘do_everything’:
koules.sndsrv.linux.c:247:22: warning: pointer targets in assignment from ‘signed char *’ to ‘char *’ differ in signedness [-Wpointer-sign]
  247 |               sample = sound_buffer[playing[i]] + position[i] * fragsize;
      |                      ^
koules.sndsrv.linux.c: In function ‘main’:
koules.sndsrv.linux.c:286:1: warning: old-style function definition [-Wold-style-definition]
  286 | main (argc, argv)
      | ^~~~
koules.sndsrv.linux.c: In function ‘read_sound’:
koules.sndsrv.linux.c:169:3: warning: ignoring return value of ‘read’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  169 |   read (fd, sound_buffer[k], size);
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
koules.sndsrv.linux.c: In function ‘do_everything’:
koules.sndsrv.linux.c:265:7: warning: ignoring return value of ‘write’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  265 |       write (dsp, final, fragsize);
      |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [<builtin>: koules.sndsrv.linux.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In function ‘ssendreliable’,
    inlined from ‘ssendreliable’ at server.c:546:1,
    inlined from ‘ssendallreliable’ at server.c:604:7,
    inlined from ‘Outro’ at server.c:660:3:
server.c:560:8: warning: array subscript 12 is above array bounds of ‘long int[12]’ [-Warray-bounds=]
  560 |   sizes[message[0]] += size;
      |   ~~~~~^~~~~~~~~~~~
server.c: In function ‘Outro’:
server.c:79:17: note: while referencing ‘sizes’
   79 | static long     sizes[MAXPACKET];
      |                 ^~~~~
In function ‘ssendreliable’,
    inlined from ‘ssendreliable’ at server.c:546:1,
    inlined from ‘ssendallreliable’ at server.c:604:7,
    inlined from ‘Outro’ at server.c:660:3:
server.c:560:8: warning: array subscript 12 is above array bounds of ‘long int[12]’ [-Warray-bounds=]
  560 |   sizes[message[0]] += size;
      |   ~~~~~^~~~~~~~~~~~
server.c: In function ‘Outro’:
server.c:79:17: note: while referencing ‘sizes’
   79 | static long     sizes[MAXPACKET];
      |                 ^~~~~
make[2]: Leaving directory '/build/reproducible-path/koules-1.4'
dh_auto_build: error: make -j8 "INSTALL=install --strip-program=true" KOULESDIR=/usr/games SOUNDDIR=/usr/lib/games/koules MANDIR=/usr/share/man/man6 returned exit code 2
make[1]: *** [debian/rules:15: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/koules-1.4'
make: *** [debian/rules:8: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2