Bug#1097304: liquidwar: ftbfs with GCC-15

[Matthias Klose]

Package: src:liquidwar
Version: 5.6.5-2
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/liquidwar_5.6.5-2_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
Compiling profile.c (cpu=default, debug=no, asm=no)
Compiling protocol.c (cpu=default, debug=no, asm=no)
Compiling random.c (cpu=default, debug=no, asm=no)
Compiling rules.c (cpu=default, debug=no, asm=no)
protocol.c: In function ‘lw_protocol_ask_who’:
protocol.c:287:32: warning: this statement may fall through [-Wimplicit-fallthrough=]
  287 |                   who->network = 1;
      |                   ~~~~~~~~~~~~~^~~
protocol.c:293:17: note: here
  293 |                 case LW_NETMESS_CODE_LOCAL:
      |                 ^~~~
Compiling score.c (cpu=default, debug=no, asm=no)
Compiling serial.c (cpu=default, debug=no, asm=no)
Compiling sock2cli.c (cpu=default, debug=no, asm=no)
Compiling sockex.c (cpu=default, debug=no, asm=no)
Compiling sockunix.c (cpu=default, debug=no, asm=no)
Compiling sound.c (cpu=default, debug=no, asm=no)
Compiling speeds.c (cpu=default, debug=no, asm=no)
Compiling startinf.c (cpu=default, debug=no, asm=no)
Compiling startup.c (cpu=default, debug=no, asm=no)
Compiling team.c (cpu=default, debug=no, asm=no)
Compiling texture.c (cpu=default, debug=no, asm=no)
Compiling thrdunix.c (cpu=default, debug=no, asm=no)
Compiling ticker.c (cpu=default, debug=no, asm=no)
thrdunix.c: In function ‘lw_thread_start’:
thrdunix.c:84:38: warning: cast between incompatible function types from ‘void (*)(void *)’ to ‘void * (*)(void *)’ [-Wcast-function-type]
   84 |   if (pthread_create (&thread, NULL, (void *(*)(void *)) func, args) == 0)
      |                                      ^
Compiling time.c (cpu=default, debug=no, asm=no)
Compiling viewport.c (cpu=default, debug=no, asm=no)
Compiling volume.c (cpu=default, debug=no, asm=no)
Compiling watchdog.c (cpu=default, debug=no, asm=no)
Compiling wave.c (cpu=default, debug=no, asm=no)
Compiling wwwcli.c (cpu=default, debug=no, asm=no)
Compiling x11icon.c (cpu=default, debug=no, asm=no)
Compiling execunix.c (cpu=default, debug=no, asm=no)
Compiling logsrv.c (cpu=default, debug=no, asm=no)
Compiling server.c (cpu=default, debug=no, asm=no)
Compiling sock2srv.c (cpu=default, debug=no, asm=no)
In file included from texture.c:64:
texture.c: In function ‘lw_texture_archive_raw’:
macro.h:70:66: warning: ‘__builtin_strncpy’ specified bound 17 equals destination size [-Wstringop-truncation]
   70 | #define LW_MACRO_STRNCPY(DST,SRC,SIZE) { memset((DST),0,(SIZE)); strncpy((DST),(SRC),(SIZE)); (DST)[(SIZE)-1]='\0'; }
      |                                                                  ^~~~~~~
macro.h:71:36: note: in expansion of macro ‘LW_MACRO_STRNCPY’
   71 | #define LW_MACRO_STRCPY(DST,SRC) { LW_MACRO_STRNCPY((DST),(SRC),sizeof(DST)); }
      |                                    ^~~~~~~~~~~~~~~~
texture.c:239:3: note: in expansion of macro ‘LW_MACRO_STRCPY’
  239 |   LW_MACRO_STRCPY (system_name_buffer, lw_path_get_system_name (filename));
      |   ^~~~~~~~~~~~~~~
Compiling srvchan.c (cpu=default, debug=no, asm=no)
Compiling srvcont.c (cpu=default, debug=no, asm=no)
Compiling srvteam.c (cpu=default, debug=no, asm=no)
srvcont.c: In function ‘lw_srvcont_wait_teams’:
Compiling srvtime.c (cpu=default, debug=no, asm=no)
srvcont.c:523:7: error: too many arguments to function ‘log_println’; expected 0, have 1
  523 |       log_println ("!");
      |       ^~~~~~~~~~~  ~~~
In file included from srvcont.c:63:
log.h:72:6: note: declared here
   72 | void log_println ();
      |      ^~~~~~~~~~~
gmake[2]: *** [Makefile:283: srvcont.o] Error 1
gmake[2]: *** Waiting for unfinished jobs....
gmake[2]: Leaving directory '/build/reproducible-path/liquidwar-5.6.5/src'
make[1]: *** [Makefile:115: build_bin] Error 2
make[1]: Leaving directory '/build/reproducible-path/liquidwar-5.6.5'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2