Bug#1097560: pcsxr: ftbfs with GCC-15

[Matthias Klose]

Package: src:pcsxr
Version: 1.9.94-7
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/pcsxr_1.9.94-7_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~
LnxMain.c: In function ‘ScanBios’:
LnxMain.c:153:33: warning: ignoring return value of ‘symlink’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  153 |                                 symlink(filename, linkname);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
LnxMain.c: In function ‘ScanPlugins’:
LnxMain.c:115:33: warning: ignoring return value of ‘symlink’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  115 |                                 symlink(filename, linkname);
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
LnxMain.c:122:41: warning: ignoring return value of ‘symlink’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  122 |                                         symlink(filename, linkname);
      |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:498: GtkGui.o] Error 1
MemcardDlg.c: In function ‘LoadListItems’:
MemcardDlg.c:180:9: warning: ‘gtk_tree_view_set_rules_hint’ is deprecated [-Wdeprecated-declarations]
  180 |         gtk_tree_view_set_rules_hint(GTK_TREE_VIEW(List), TRUE);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gtk/gtkcombobox.h:27,
                 from /usr/include/gtk-3.0/gtk/gtkappchooserbutton.h:29,
                 from /usr/include/gtk-3.0/gtk/gtk.h:42,
                 from MemcardDlg.c:24:
/usr/include/gtk-3.0/gtk/gtktreeview.h:246:24: note: declared here
  246 | void                   gtk_tree_view_set_rules_hint                (GtkTreeView               *tree_view,
      |                        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
MemcardDlg.c: In function ‘OnMcd_FileChange’:
MemcardDlg.c:307:17: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
  307 |                 GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
      |                 ^~~~~~~~~~~~~~~~
MemcardDlg.c:308:17: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
  308 |                 GTK_STOCK_OPEN, GTK_RESPONSE_OK,
      |                 ^~~~~~~~~~~~~~
MemcardDlg.c: In function ‘OnMcd_Format’:
MemcardDlg.c:349:17: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
  349 |                 GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
      |                 ^~~~~~~~~~~~~~~~
MemcardDlg.c: In function ‘OnMcd_New’:
MemcardDlg.c:374:17: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
  374 |                 GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
      |                 ^~~~~~~~~~~~~~~~
MemcardDlg.c:375:17: warning: ‘GtkStock’ is deprecated [-Wdeprecated-declarations]
  375 |                 GTK_STOCK_SAVE, GTK_RESPONSE_OK,
      |                 ^~~~~~~~~~~~~~
Plugin.c: In function ‘_OpenPlugins’:
Plugin.c:376:34: warning: ‘%s’ directive writing up to 4095 bytes into a region of size between 1 and 4096 [-Wformat-overflow=]
  376 |                 sprintf(path, "%s%s", Config.BiosDir, Config.Bios);
      |                                  ^~                   ~~~~~~~~~~~
In file included from /usr/include/stdio.h:970,
                 from Plugin.c:19:
In function ‘sprintf’,
    inlined from ‘_OpenPlugins’ at Plugin.c:376:3:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:30:10: note: ‘__builtin___sprintf_chk’ output between 1 and 8191 bytes into a destination of size 4096
   30 |   return __builtin___sprintf_chk (__s, __USE_FORTIFY_LEVEL - 1,
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   31 |                                   __glibc_objsize (__s), __fmt,
      |                                   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   32 |                                   __va_arg_pack ());
      |                                   ~~~~~~~~~~~~~~~~~
LnxMain.c: In function ‘main’:
LnxMain.c:313:49: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
  313 |                         isofilename[MAXPATHLEN] = '\0';
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
LnxMain.c:309:30: note: at offset 4096 into destination object ‘isofilename’ of size 4096
  309 |                         char isofilename[MAXPATHLEN];
      |                              ^~~~~~~~~~~
make[2]: Leaving directory '/build/reproducible-path/pcsxr-1.9.94/gui'
make[1]: *** [Makefile:457: all-recursive] Error 1
make[1]: Leaving directory '/build/reproducible-path/pcsxr-1.9.94'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2