Bug#1097621: pmars: ftbfs with GCC-15

[Matthias Klose]

Package: src:pmars
Version: 0.9.4-1
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/pmars_0.9.4-1_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
xwindisp.c:707:1: warning: old-style function definition [-Wold-style-definition]
  707 | conv_key(event)
      | ^~~~~~~~
xwindisp.c: In function ‘mouse_or_key’:
xwindisp.c:748:1: warning: old-style function definition [-Wold-style-definition]
  748 | mouse_or_key(result, key)
      | ^~~~~~~~~~~~
xwindisp.c: In function ‘special_keys’:
xwindisp.c:803:1: warning: old-style function definition [-Wold-style-definition]
  803 | special_keys(key, buf)
      | ^~~~~~~~~~~~
xwindisp.c: In function ‘xWin_gets’:
xwindisp.c:911:1: warning: old-style function definition [-Wold-style-definition]
  911 | xWin_gets(result, maxchar)
      | ^~~~~~~~~
xwindisp.c: In function ‘handle_event’:
xwindisp.c:1007:1: warning: old-style function definition [-Wold-style-definition]
 1007 | handle_event(event)
      | ^~~~~~~~~~~~
xwindisp.c: In function ‘setcolor’:
xwindisp.c:1101:1: warning: old-style function definition [-Wold-style-definition]
 1101 | setcolor(c)
      | ^~~~~~~~
xwindisp.c: In function ‘xWin_cleartextxy’:
xwindisp.c:1127:1: warning: old-style function definition [-Wold-style-definition]
 1127 | xWin_cleartextxy(x, y, gc)
      | ^~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_outtextxy’:
xwindisp.c:1145:1: warning: old-style function definition [-Wold-style-definition]
 1145 | xWin_outtextxy(x, y, s)
      | ^~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_read’:
xwindisp.c:1333:1: warning: old-style function definition [-Wold-style-definition]
 1333 | xWin_display_read(addr)
      | ^~~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_dec’:
xwindisp.c:1346:1: warning: old-style function definition [-Wold-style-definition]
 1346 | xWin_display_dec(addr)
      | ^~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_inc’:
xwindisp.c:1363:1: warning: old-style function definition [-Wold-style-definition]
 1363 | xWin_display_inc(addr)
      | ^~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_write’:
xwindisp.c:1380:1: warning: old-style function definition [-Wold-style-definition]
 1380 | xWin_display_write(addr)
      | ^~~~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_exec’:
xwindisp.c:1399:1: warning: old-style function definition [-Wold-style-definition]
 1399 | xWin_display_exec(addr)
      | ^~~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_spl’:
xwindisp.c:1414:1: warning: old-style function definition [-Wold-style-definition]
 1414 | xWin_display_spl(warrior, tasks)
      | ^~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_dat’:
xwindisp.c:1427:1: warning: old-style function definition [-Wold-style-definition]
 1427 | xWin_display_dat(addr, warNum, tasks)
      | ^~~~~~~~~~~~~~~~
xwindisp.c: In function ‘xWin_display_close’:
xwindisp.c:1497:1: warning: old-style function definition [-Wold-style-definition]
 1497 | xWin_display_close(wait)
      | ^~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:59: sim.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/pmars-0.9.4/src'
dh_auto_build: error: cd src && make -j8 "INSTALL=install --strip-program=true" returned exit code 2
make[1]: *** [debian/rules:9: override_dh_auto_build] Error 25
make[1]: Leaving directory '/build/reproducible-path/pmars-0.9.4'
make: *** [debian/rules:6: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2