Bug#1098123: xbubble: ftbfs with GCC-15

[Matthias Klose]

Package: src:xbubble
Version: 0.5.11.2-4
Severity: important
Tags: sid forky
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-15

[This bug is NOT targeted to the upcoming trixie release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-15/g++-15, but succeeds to build with gcc-14/g++-14. The
severity of this report will be raised before the forky release.

The full build log can be found at:
http://qa-logs.debian.net/2025/02/16/amd64exp/xbubble_0.5.11.2-4_unstable_gccexp.log.gz
The last lines of the build log are at the end of this report.

To build with GCC 15, either set CC=gcc-15 CXX=g++-15 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

GCC 15 now defaults to the C23/C++23 standards, exposing many FTBFS.
Other Common build failures are new warnings resulting in build failures
with -Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-15/porting_to.html

[...]
      |                    ~~~~~~~~~~~~~~~~~~~^~~~~~~
opponent.c: In function ‘eval_tree.constprop’:
opponent.c:56:7: note: while referencing ‘removed_bubbles’
   56 |   Set removed_bubbles[MAX_DEPTH];
      |       ^~~~~~~~~~~~~~~
In function ‘unplay_move’,
    inlined from ‘eval_tree’ at opponent.c:454:7,
    inlined from ‘eval_tree’ at opponent.c:451:14,
    inlined from ‘eval_tree’ at opponent.c:451:14,
    inlined from ‘eval_tree.constprop’ at opponent.c:451:14:
opponent.c:211:27: warning: array subscript 4 is above array bounds of ‘int[3]’ [-Warray-bounds=]
  211 |   op->array->cell[op->line[depth]] = EMPTY_CELL;
      |                   ~~~~~~~~^~~~~~~
opponent.c: In function ‘eval_tree.constprop’:
opponent.c:46:7: note: while referencing ‘line’
   46 |   int line[MAX_DEPTH];
      |       ^~~~
In function ‘compute_targets’,
    inlined from ‘eval_tree’ at opponent.c:431:5,
    inlined from ‘eval_tree’ at opponent.c:451:14,
    inlined from ‘eval_tree’ at opponent.c:451:14,
    inlined from ‘eval_tree.constprop’ at opponent.c:451:14:
opponent.c:289:9: warning: array subscript 4 is above array bounds of ‘struct _Vector *[3]’ [-Warray-bounds=]
  289 |         vector_push( op->targets[depth], target );
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
opponent.c: In function ‘eval_tree.constprop’:
opponent.c:59:10: note: while referencing ‘targets’
   59 |   Vector targets[MAX_DEPTH];
      |          ^~~~~~~
In function ‘unplay_move’,
    inlined from ‘eval_tree’ at opponent.c:454:7,
    inlined from ‘eval_tree’ at opponent.c:451:14,
    inlined from ‘eval_tree.constprop’ at opponent.c:451:14:
opponent.c:206:39: warning: array subscript 3 is above array bounds of ‘struct _Set *[3]’ [-Warray-bounds=]
  206 |   for ( i = 0; i < op->removed_bubbles[depth]->size; i++ ) {
      |                    ~~~~~~~~~~~~~~~~~~~^~~~~~~
opponent.c: In function ‘eval_tree.constprop’:
opponent.c:56:7: note: while referencing ‘removed_bubbles’
   56 |   Set removed_bubbles[MAX_DEPTH];
      |       ^~~~~~~~~~~~~~~
In function ‘unplay_move’,
    inlined from ‘eval_tree’ at opponent.c:454:7,
    inlined from ‘eval_tree’ at opponent.c:451:14,
    inlined from ‘eval_tree.constprop’ at opponent.c:451:14:
opponent.c:211:27: warning: array subscript 3 is above array bounds of ‘int[3]’ [-Warray-bounds=]
  211 |   op->array->cell[op->line[depth]] = EMPTY_CELL;
      |                   ~~~~~~~~^~~~~~~
opponent.c: In function ‘eval_tree.constprop’:
opponent.c:46:7: note: while referencing ‘line’
   46 |   int line[MAX_DEPTH];
      |       ^~~~
In function ‘compute_targets’,
    inlined from ‘eval_tree’ at opponent.c:431:5,
    inlined from ‘eval_tree’ at opponent.c:451:14,
    inlined from ‘eval_tree.constprop’ at opponent.c:451:14:
opponent.c:289:9: warning: array subscript 3 is above array bounds of ‘struct _Vector *[3]’ [-Warray-bounds=]
  289 |         vector_push( op->targets[depth], target );
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
opponent.c: In function ‘eval_tree.constprop’:
opponent.c:59:10: note: while referencing ‘targets’
   59 |   Vector targets[MAX_DEPTH];
      |          ^~~~~~~
make[3]: Leaving directory '/build/reproducible-path/xbubble-0.5.11.2/src'
make[2]: *** [Makefile:330: all] Error 2
make[2]: Leaving directory '/build/reproducible-path/xbubble-0.5.11.2/src'
make[1]: *** [Makefile:377: all-recursive] Error 1
make[1]: Leaving directory '/build/reproducible-path/xbubble-0.5.11.2'
dh_auto_build: error: make -j8 returned exit code 2
make: *** [debian/rules:14: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2