Bug#1106918: steam-installer: add libcrypt-dev to Build-Depends

[Simon McVittie]

Control: tags -1 + moreinfo forky

On Sat, 31 May 2025 at 21:09:50 +0200, helmut at subdivi.de wrote:
>please add "libcrypt-dev" to Build-Depends. Presently, libcrypt-dev is
>transitively build-essential, because libc6-dev depends on it. There is an
>effort[1] to drop this dependency with the result of removing libcrypt-dev from
>the build-essential package set. This package was identified as needing an
>explicit dependency on libcrypt-dev for one or more of several reasons:
> * It failed building in an archive-rebuild with the dependency dropped.
> * One of its binary packages issues a binary package dependency on libcrypt1.
> * Inspection of source identified "#include <crypt.h>" or -lcrypt.

I think this might be a false positive for steam-installer: the 
dependency on libcrypt1 is hard-coded, because nothing in 
steam-installer actually depends on it. (Instead, it downloads 
proprietary binaries from Valve on-demand at runtime, some of which do 
require libcrypt, or at least *might* require it - it's not entirely 
obvious, because of libcrypt's status as formerly part of glibc.)

I think the best way to approach this would be to wait until there's a 
libc-dev in experimental that has dropped this dependency during the 
forky cycle, try rebuilding steam-installer against it and see what 
happens. If there is genuinely a problem then adding the B-D would be an 
easy change to make.

     smcv