Bug#1120608: ignores duplicate files in ZIP archives (simon1)

[Dmitry Baryshkov]

Package: game-data-packager
Version: 85.1
Severity: normal

The extractor of GDP ignores duplicate files in ZIP files. For example,
if running GDP on the archive from GOG

$ game-data-packager simon1 --no-download simon_the_sorcerer_en_gog_1_19763.sh
[...]
ERROR:game_data_packager.build:simon_the_sorcerer_en_gog_1_19763.sh should have provided 0032.vga but did not
ERROR:game_data_packager.build:simon_the_sorcerer_en_gog_1_19763.sh should have provided 1522.vga but did not
ERROR:game_data_packager.build:simon_the_sorcerer_en_gog_1_19763.sh should have provided sfxxxx18 but did not
ERROR:game_data_packager.build:simon_the_sorcerer_en_gog_1_19763.sh should have provided sfxxxx19 but did not

However if I manually unzip the archive, GDP correctly finds these
files.

-- System Information:
Debian Release: 13.1
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.16.3+deb13-amd64 (SMP w/32 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_WARN, TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages game-data-packager depends on:
ii  python3         3.13.5-1
ii  python3-debian  1.0.1
ii  python3-yaml    6.0.2-1+b2

Versions of packages game-data-packager recommends:
ii  game-data-packager-runtime  85.1

Versions of packages game-data-packager suggests:
ii  7zip                              24.09+dfsg-8
ii  arj                               3.10.22-28
ii  binutils                          2.44-3
ii  cabextract                        1.11-2
ii  cdparanoia                        3.10.2+debian-14+b1
ii  dynamite                          0.1.1-2+b4
ii  gcc                               4:14.2.0-1
ii  gdebi                             0.9.5.8
ii  gir1.2-gdkpixbuf-2.0              2.42.12+dfsg-4
ii  innoextract                       1.9-0.1+b1
ii  lame                              3.100-6+b3
ii  lgc-pg                            1.4.4-4
ii  lgogdownloader                    3.17-1
ii  lhasa [lzh-archiver]              0.4.0-1+b2
ii  make                              4.4.1-2
ii  pkexec                            126-2
ii  python3-gi                        3.50.0-4+b1
ii  python3-omg                       0.5.1-1
ii  python3-pil                       11.1.0-5+b1
ii  steam-launcher [steam-installer]  1:1.0.0.85
ii  steamcmd                          0~20180105-5
ii  unace-nonfree                     2.5-10
ii  unar                              1.10.8+ds1-9
ii  unrar                             1:7.1.8-1
ii  unshield                          1.5.1-1+b2
ii  unzip                             6.0-29
ii  vorbis-tools                      1.4.3-1
ii  xdelta                            1.1.3-10.7
ii  xdelta3                           3.0.11-dfsg-1.2
ii  xorriso                           1.5.6-1.2+b1

-- no debconf information