Bug#1133436: burgerspace: ftbfs with GCC-16

[Emanuele Rocca]

Package: src:burgerspace
Version: 1.10.0-1
Severity: important
Tags: sid forky ftbfs
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-16

Hi,

burgerspace fails to build in a test rebuild on at least amd64 and arm64 with
gcc-16/g++-16, but builds properly with gcc-15/g++-15. The severity of this
report will be raised before the forky release.

The full build log can be found at:
https://people.debian.org/~ema/gcc-16-rebuilds/output-1/burgerspace_arm64.build.xz

The last lines of the build log are at the end of this report.

To build with GCC 16, either set CC=gcc-16 CXX=g++-16 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures include unused (but set) variables, array subscripts
partly outside array bounds, and new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-16/porting_to.html

Please only close this issue after double-checking that the package can be
built correctly with GCC 16.

Please do not reassign this bug to another package. If a fix in another package
is required, then file a bug for the other package (or clone), and mark this
bug as blocked by the bug in the other package.

[...]


checking whether build environment is sane... yes
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... no
checking for mawk... mawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking xargs -n works... yes
checking whether UID '999' is supported by ustar format... yes
checking whether GID '999' is supported by ustar format... yes
checking how to create a ustar tar archive... gnutar
checking for g++... g++
checking whether the C++ compiler works... yes
checking for C++ compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether the compiler supports GNU C++... yes
checking whether g++ accepts -g... yes
checking for g++ option to enable C++11 features... -std=gnu++11
checking whether make supports the include directive... yes (GNU style)
checking dependency style of g++ -std=gnu++11... none
checking maximum warning verbosity option... -W -Wall for C++
checking for pkg-config... /usr/bin/pkg-config
checking pkg-config is at least version 0.9.0... yes
checking for flatzebra-0.2 >= 0.2.0... yes
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for getopt.h... yes
checking for getopt_long... yes
checking if C++ compiler supports -Wsuggest-override... yes
checking that generated files are newer than configure... done
configure: creating ./config.status
config.status: creating Makefile
config.status: creating burgerspace.spec
config.status: creating src/Makefile
config.status: creating src/burgerspace.desktop
config.status: creating doc/burgerspace.6
config.status: creating doc/burgerspace-server.6
config.status: executing depfiles commands
make[1]: Leaving directory '/build/reproducible-path/burgerspace-1.10.0'
   dh_auto_build
	make -j128
make[1]: Entering directory '/build/reproducible-path/burgerspace-1.10.0'
Making all in src
make[2]: Entering directory '/build/reproducible-path/burgerspace-1.10.0/src'
g++ -std=gnu++11 -DPACKAGE_NAME=\"burgerspace\" -DPACKAGE_TARNAME=\"burgerspace\" -DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"burgerspace\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"burgerspace\" -DVERSION=\"1.10.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_GETOPT_LONG=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DPROGRAM=\"burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGSOUNDDIR=\"/usr/share/burgerspace/sounds\" -DDEFAULT_UDP_SERVER_PORT= -I../src/images -Wsuggest-override -I/usr/include/flatzebra-0.2 -I/usr/include/SDL2 -I/usr/include/libpng16 -I/usr/include/aarch64-linux-gnu -I/usr/include/webp -I/usr/include/opus -D_REENTRANT -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -g -O2 -ffile-prefix-map=/build/reproducible-path/burgerspace-1.10.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -W -Wall -c -o burgerspace-main.o `test -f 'main.cpp' || echo './'`main.cpp
g++ -std=gnu++11 -DPACKAGE_NAME=\"burgerspace\" -DPACKAGE_TARNAME=\"burgerspace\" -DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"burgerspace\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"burgerspace\" -DVERSION=\"1.10.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_GETOPT_LONG=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DPROGRAM=\"burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGSOUNDDIR=\"/usr/share/burgerspace/sounds\" -DDEFAULT_UDP_SERVER_PORT= -I../src/images -Wsuggest-override -I/usr/include/flatzebra-0.2 -I/usr/include/SDL2 -I/usr/include/libpng16 -I/usr/include/aarch64-linux-gnu -I/usr/include/webp -I/usr/include/opus -D_REENTRANT -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -g -O2 -ffile-prefix-map=/build/reproducible-path/burgerspace-1.10.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -W -Wall -c -o burgerspace-BurgerSpaceEngine.o `test -f 'BurgerSpaceEngine.cpp' || echo './'`BurgerSpaceEngine.cpp
g++ -std=gnu++11 -DPACKAGE_NAME=\"burgerspace\" -DPACKAGE_TARNAME=\"burgerspace\" -DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"burgerspace\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"burgerspace\" -DVERSION=\"1.10.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_GETOPT_LONG=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DPROGRAM=\"burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGSOUNDDIR=\"/usr/share/burgerspace/sounds\" -DDEFAULT_UDP_SERVER_PORT= -I../src/images -Wsuggest-override -I/usr/include/flatzebra-0.2 -I/usr/include/SDL2 -I/usr/include/libpng16 -I/usr/include/aarch64-linux-gnu -I/usr/include/webp -I/usr/include/opus -D_REENTRANT -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -g -O2 -ffile-prefix-map=/build/reproducible-path/burgerspace-1.10.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -W -Wall -c -o burgerspace-IngredientGroup.o `test -f 'IngredientGroup.cpp' || echo './'`IngredientGroup.cpp
g++ -std=gnu++11 -DPACKAGE_NAME=\"burgerspace\" -DPACKAGE_TARNAME=\"burgerspace\" -DPACKAGE_VERSION=\"1.10.0\" -DPACKAGE_STRING=\"burgerspace\ 1.10.0\" -DPACKAGE_BUGREPORT=\"\" -DPACKAGE_URL=\"\" -DPACKAGE=\"burgerspace\" -DVERSION=\"1.10.0\" -DHAVE_STDIO_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_STRINGS_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_UNISTD_H=1 -DSTDC_HEADERS=1 -DHAVE_GETOPT_LONG=1 -I.   -Wdate-time -D_FORTIFY_SOURCE=2 -DPROGRAM=\"burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGPIXMAPDIR=\"/usr/share/pixmaps/burgerspace\" -DPKGSOUNDDIR=\"/usr/share/burgerspace/sounds\" -DDEFAULT_UDP_SERVER_PORT= -I../src/images -Wsuggest-override -I/usr/include/flatzebra-0.2 -I/usr/include/SDL2 -I/usr/include/libpng16 -I/usr/include/aarch64-linux-gnu -I/usr/include/webp -I/usr/include/opus -D_REENTRANT -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/aarch64-linux-gnu/glib-2.0/include -I/usr/include/sysprof-6 -pthread -g -O2 -ffile-prefix-map=/build/reproducible-path/burgerspace-1.10.0=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -mbranch-protection=standard -W -Wall -c -o burgerspace-EnemySprite.o `test -f 'EnemySprite.cpp' || echo './'`EnemySprite.cpp
BurgerSpaceEngine.cpp: In member function ‘void BurgerSpaceEngine::doSaveDialog(SDL_Keycode)’:
BurgerSpaceEngine.cpp:3975:18: error: aggregate ‘std::stringstream msg’ has incomplete type and cannot be defined
 3975 |     stringstream msg;
      |                  ^~~
BurgerSpaceEngine.cpp: In member function ‘void BurgerSpaceEngine::doLoadDialog(SDL_Keycode)’:
BurgerSpaceEngine.cpp:4030:18: error: aggregate ‘std::stringstream msg’ has incomplete type and cannot be defined
 4030 |     stringstream msg;
      |                  ^~~
make[2]: *** [Makefile:623: burgerspace-BurgerSpaceEngine.o] Error 1
make[2]: Leaving directory '/build/reproducible-path/burgerspace-1.10.0/src'
make[1]: *** [Makefile:494: all-recursive] Error 1
make[1]: Leaving directory '/build/reproducible-path/burgerspace-1.10.0'
dh_auto_build: error: make -j128 returned exit code 2
make: *** [debian/rules:7: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2