Bug#1133544: marsshooter: ftbfs with GCC-16

[Emanuele Rocca]

Package: src:marsshooter
Version: 0.7.6-10
Severity: important
Tags: sid forky ftbfs
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-16

Hi,

marsshooter fails to build in a test rebuild on at least amd64 and arm64 with
gcc-16/g++-16, but builds properly with gcc-15/g++-15. The severity of this
report will be raised before the forky release.

The full build log can be found at:
https://people.debian.org/~ema/gcc-16-rebuilds/output-1/marsshooter_arm64.build.xz

The last lines of the build log are at the end of this report.

To build with GCC 16, either set CC=gcc-16 CXX=g++-16 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures include unused (but set) variables, array subscripts
partly outside array bounds, and new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-16/porting_to.html

Please only close this issue after double-checking that the package can be
built correctly with GCC 16.

Please do not reassign this bug to another package. If a fix in another package
is required, then file a bug for the other package (or clone), and mark this
bug as blocked by the bug in the other package.

[...]


  304 |         window_.setActive(true);
      |         ~~~~~~~~~~~~~~~~~^~~~~~
/usr/include/SFML/Graphics/RenderWindow.hpp:179:24: note: declared here
  179 |     [[nodiscard]] bool setActive(bool active = true) override;
      |                        ^~~~~~~~~
/build/reproducible-path/marsshooter-0.7.6/src/Weapons/weapons.cpp: In function ‘Weapon* weapons::createPrev(WeaponType, Ship*)’:
/build/reproducible-path/marsshooter-0.7.6/src/Weapons/weapons.cpp:76:46: warning: arithmetic between enumeration type ‘weapons::WeaponType’ and floating-point type ‘double’ is deprecated [-Wdeprecated-enum-float-conversion]
   76 |         int next(type == 1 ? wNoWeapon : type*0.5), i(1);
      |                                          ~~~~^~~~
/build/reproducible-path/marsshooter-0.7.6/src/Weapons/weapons.cpp:76:28: warning: conditional expression between enumeration type ‘weapons::WeaponType’ and floating-point type ‘double’ is deprecated [-Wdeprecated-enum-float-conversion]
   76 |         int next(type == 1 ? wNoWeapon : type*0.5), i(1);
      |                  ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~
/build/reproducible-path/marsshooter-0.7.6/src/System/settings.cpp: In function ‘bool settings::save()’:
/build/reproducible-path/marsshooter-0.7.6/src/System/settings.cpp:166:43: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, char32_t) [with _Traits = char_traits<char>]’
  166 |                 outStream<<C_playerIName[i]<<" ";
      |                                           ^
In file included from /usr/include/c++/16/bits/unique_ptr.h:42,
                 from /usr/include/c++/16/memory:80,
                 from /usr/include/SFML/Window/GlResource.hpp:32,
                 from /usr/include/SFML/Graphics/Texture.hpp:35,
                 from /usr/include/SFML/Graphics/Font.hpp:34,
                 from /usr/include/SFML/Graphics.hpp:36,
                 from /build/reproducible-path/marsshooter-0.7.6/include/System/Color3f.hpp:23,
                 from /build/reproducible-path/marsshooter-0.7.6/include/System/settings.hpp:21,
                 from /build/reproducible-path/marsshooter-0.7.6/src/System/settings.cpp:18:
/usr/include/c++/16/bits/ostream.h:681:5: note: declared here
  681 |     operator<<(basic_ostream<char, _Traits>&, char32_t) = delete;
      |     ^~~~~~~~
/build/reproducible-path/marsshooter-0.7.6/src/System/settings.cpp:166:43: note: use ‘-fdiagnostics-all-candidates’ to display considered candidates
  166 |                 outStream<<C_playerIName[i]<<" ";
      |                                           ^
/build/reproducible-path/marsshooter-0.7.6/src/System/settings.cpp:181:44: error: use of deleted function ‘std::basic_ostream<char, _Traits>& std::operator<<(basic_ostream<char, _Traits>&, char32_t) [with _Traits = char_traits<char>]’
  181 |                 outStream<<C_playerIIName[i]<<" ";
      |                                            ^
/usr/include/c++/16/bits/ostream.h:681:5: note: declared here
  681 |     operator<<(basic_ostream<char, _Traits>&, char32_t) = delete;
      |     ^~~~~~~~
/build/reproducible-path/marsshooter-0.7.6/src/System/settings.cpp:181:44: note: use ‘-fdiagnostics-all-candidates’ to display considered candidates
  181 |                 outStream<<C_playerIIName[i]<<" ";
      |                                            ^
/build/reproducible-path/marsshooter-0.7.6/src/System/generateName.cpp: In function ‘void generateName::{anonymous}::init_()’:
/build/reproducible-path/marsshooter-0.7.6/src/System/generateName.cpp:124:36: warning: ‘void std::random_shuffle(_RAIter, _RAIter) [with _RAIter = __gnu_cxx::__normal_iterator<pair<sf::String, int>*, vector<pair<sf::String, int> > >]’ is deprecated: use 'std::shuffle' instead [-Wdeprecated-declarations]
  124 |                 std::random_shuffle(temp.begin(), temp.end());
      |                 ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/c++/16/chrono:57,
                 from /usr/include/SFML/System/Time.hpp:30,
                 from /usr/include/SFML/Window/WindowBase.hpp:36,
                 from /usr/include/SFML/Window/Window.hpp:32,
                 from /usr/include/SFML/Window.hpp:42,
                 from /build/reproducible-path/marsshooter-0.7.6/include/System/Key.hpp:21,
                 from /build/reproducible-path/marsshooter-0.7.6/include/System/generateName.hpp:21,
                 from /build/reproducible-path/marsshooter-0.7.6/src/System/generateName.cpp:18:
/usr/include/c++/16/bits/stl_algo.h:4515:5: note: declared here
 4515 |     random_shuffle(_RandomAccessIterator __first, _RandomAccessIterator __last)
      |     ^~~~~~~~~~~~~~
/build/reproducible-path/marsshooter-0.7.6/src/System/generateName.cpp:132:32: warning: ‘void std::random_shuffle(_RAIter, _RAIter) [with _RAIter = __gnu_cxx::__normal_iterator<sf::String*, vector<sf::String> >]’ is deprecated: use 'std::shuffle' instead [-Wdeprecated-declarations]
  132 |             std::random_shuffle(temp2.begin(), temp2.end());
      |             ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
/usr/include/c++/16/bits/stl_algo.h:4515:5: note: declared here
 4515 |     random_shuffle(_RandomAccessIterator __first, _RandomAccessIterator __last)
      |     ^~~~~~~~~~~~~~
make[3]: *** [src/CMakeFiles/marsshooter.dir/build.make:2336: src/CMakeFiles/marsshooter.dir/System/settings.cpp.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/build/reproducible-path/marsshooter-0.7.6/obj-aarch64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:109: src/CMakeFiles/marsshooter.dir/all] Error 2
make[2]: Leaving directory '/build/reproducible-path/marsshooter-0.7.6/obj-aarch64-linux-gnu'
make[1]: *** [Makefile:159: all] Error 2
make[1]: Leaving directory '/build/reproducible-path/marsshooter-0.7.6/obj-aarch64-linux-gnu'
dh_auto_build: error: cd obj-aarch64-linux-gnu && make -j128 INSTALL="install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:5: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess failed with exit status 2