Bug#1078938: bsdgames: Cannot Launch from GNOME menu (various issues with desktop files including Terminal= should be true)

[Bela Lubkin]

Notwithstanding the bogus reporter email address -- this bug is true and
reproducible.  Tested against bsdgames 2.17-35

For the package maintainer:

- just change 'Terminal=True' to 'Terminal=true' in all the files.  The
'.desktop' file format is case-sensitive
- commit
- consider removing some of the .desktop files in the future, as some of
the filter commands just don't make sense as GUI apps

=====

For current users:

This is fixable in the field by editing the
/usr/share/applications/bsdgames/*.desktop files.

Having done that, it was an exercise in frustration getting the Gnome 49
Wayland desktop to recognize the changes.  Logging out and back in *did*
work, but I wanted to find a method that didn't involve logging out.

Much experimentation later, this sequence seems to work, although it
involves too much manual intervention:

[PART 1]

Open a terminal in which to run:

$ cd /usr/share/applications
$ sudo sed -i 's/Terminal=True/Terminal=true/' bsdgames/*.desktop
$ sudo mv bsdgames BADgames

[PART 2]

Open and close the Gnome desktop applications picker (e.g.: 'win' key, then
'9-dots' icon).

[PART 3]

$ sudo mv BADgames bsdgames

[PART 4]

Open and close the Gnome desktop applications picker.

-- in other words, just rename the directory away and back again (after
having fixed the *.desktop files); with some GUI actions in between to make
sure it actually noticed the changes.  Whatever caches the *.desktop files
is apparently watchfully paying attention to file existence, but not *at
all* to file content changes.

None of these suggestions on the web worked:

NO: $ [ sudo or not ] xdg-desktop-menu forceupdate

NO: $ [ sudo or not ] dbus-send --session --type=method_call
--dest=org.gnome.Shell /org/gnome/Shell org.gnome.Shell.Eval
string:"global.desktop_icons_provider.refresh()"

NO: $ sudo update-desktop-database

NO: $ sudo update-desktop-database /usr/share/applications/bsdgames

NO: Lock and unlock my session

NO: Alt+F2 'r' ('Restart is not available on Wayland')

Those suggestions might work for other environments (KDE, other DEs, X11
session of Gnome, etc.)?

> The games themselves work fine from
> command line, but in addtion to menu not starting them, if I use
gtk-launch it
> won't find them in /usr/share/applications/bsdgames, only if I move them
to
> /usr/share/applications.

According to the spec, /usr/share/applications/SUBDIR/WHATEVER.desktop is
known for launching purposes as 'SUBDIR-WHATEVER'; and, indeed, all of
these:

$ gtk-launch bsdgames-cribbage
$ gtk4-launch bsdgames-cribbage
$ gio launch /usr/share/applications/bsdgames/cribbage.desktop

work fine -- after repairing the *.desktop files.  (I'm sure I've missed
half the arcane invocations for 'launch this here desktop file'...)

>Bela<