Bug#1130332: rocksndiamonds: installation of Rocksndiamonds-the-game from its source-and-binary tarball is incomplete

[Bela Lubkin]

Package: rocksndiamonds
Version: 4.4.1.3+dfsg-1
Severity: important
X-Debbugs-Cc: bela.lubkin at gmail.com

Dear Maintainer,

The Debian postinst script for rocksndiamonds downloads and unpacks the upstream author's distribution tarball, discarding parts which are not needed (source, and the author's built binary, in favor of Debian's).  This is reasonable.

In the process, it discards a few files which are actually needed.  The code in question is:

    if ($section =~ /Base games/i)
    {
        cmd_execute "cp -r $tempdir/$topdir/$_ $game_dir"
            for (qw(graphics levels music sounds));
    }

which causes it to copy those four top-level directories of the tarball.  It should also copy directories 'docs' and 'conf'; therefore it would *probably* be sufficient to change to:

            for (qw(graphics levels music sounds docs conf));

(and the corresponding line at the end of clean_downloads_dir()).

'conf' contains one file at the moment: a database of game controller information.  Without this, the game cannot properly take advantage of gaming hardware on the user's system (joysticks, etc.)

'docs' contains in-game documentation, particularly for the level editor.  Level editing is an integral part of the overall game experience.  Without the docs directory, users can still edit levels, but descriptions of the game elements are absent.  (This is the reason I marked 'important'.)

Answering the questions in the template:

What led to it?  Installing the .deb package and examining the results.

What did I expect?  Fully installed game with all original features (missing: element docs in the editor, game controller config).

=====

Two other buglets which I should report separately, but will state here.  If the person picking up the primary bug doesn't want to deal with these, email me a Sternly Worded Note to get official bugs:

1. the URL recorded for 'rnd_jue', 'http://www.jb-line.de/hp/rnd_jue-v8.zip', is out of date.  I chased it around on the author's site and found it at 'https://jb-line.de/rnd17/rnd_jue-v8.zip'; another choice is a Wayback Machine link, https://web.archive.org/web/20230702180255/http://www.jb-line.de/hp/rnd_jue-v8.zip -- those never seem like a great choice, but given how it keeps jumping around on the author's site, maybe the right on in this case?

2. in extracting 'r-structure.zip', a single example level (and its corresponding configuration files) is lost.  This is the subdirectory starting at 'levels/Examples/example_richard_kleber/' inside the zip file.

-- System Information:
Debian Release: forky/sid
  APT prefers unstable
  APT policy: (900, 'unstable'), (500, 'stable-updates'), (500, 'stable-security'), (500, 'testing'), (100, 'stable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.17.13+deb14-amd64 (SMP w/14 CPU threads; PREEMPT)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages rocksndiamonds depends on:
ii  7zip                   26.00+dfsg-2
ii  debconf [debconf-2.0]  1.5.92
ii  libc6                  2.42-13
ii  libsdl2-2.0-0          2.32.10+dfsg-6
ii  libsdl2-image-2.0-0    2.8.8+dfsg-2
ii  libsdl2-mixer-2.0-0    2.8.1+dfsg-5
ii  libsdl2-net-2.0-0      2.2.0+dfsg-4
ii  perl                   5.40.1-7
ii  unzip                  6.0-29
ii  wget                   1.25.0-2
ii  zip                    3.0-15
ii  zlib1g                 1:1.3.dfsg+really1.3.1-3

rocksndiamonds recommends no packages.

rocksndiamonds suggests no packages.

-- debconf information excluded