[Pkg-geany-team] Bug#798870: geany-plugins: FTBFS with libgit2 0.23.1

[Andreas Beckmann]

Package: geany-plugins
Version: 1.25+dfsg-1
Severity: serious
Justification: fails to build from source (but built successfully in the past)

geany-plugins fails to build with the new libgit2 in sid:

[...]
Making all in src
make[4]: Entering directory '/«BUILDDIR»/geany-plugins-1.25+dfsg/git-changebar/src'
/bin/bash ../../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I../..   -DG_LOG_DOMAIN=\"GitChangeBar\" -DPLUGIN=\""git-changebar"\" -D_FORTIFY_SOURCE=2 -DLOCALEDIR=\""/usr/share/locale"\" -DPREFIX=\""/usr"\" -DDOCDIR=\""/usr/share/doc/geany-plugins"\" -DGEANYPLUGINS_DATADIR=\""/usr/share"\" -DPKGDATADIR=\""/usr/share/geany-plugins"\" -DLIBDIR=\""/usr/lib/x86_64-linux-gnu"\" -DPKGLIBDIR=\""/usr/lib/x86_64-linux-gnu/geany-plugins"\" -DGTK -pthread -I/usr/include/geany -I/usr/include/geany/tagmanager -I/usr/include/geany/scintilla -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/in
 clude  -Wall -Wimplicit-function-declaration -Wmissing-parameter-type -Wold-style-declaration -Wpointer-arith -Wshadow -Wundef -Wwrite-strings -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include  -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c -o git_changebar_la-gcb-plugin.lo `test -f 'gcb-plugin.c' || echo './'`gcb-plugin.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I../.. -DG_LOG_DOMAIN=\"GitChangeBar\" -DPLUGIN=\"git-changebar\" -D_FORTIFY_SOURCE=2 -DLOCALEDIR=\"/usr/share/locale\" -DPREFIX=\"/usr\" -DDOCDIR=\"/usr/share/doc/geany-plugins\" -DGEANYPLUGINS_DATADIR=\"/usr/share\" -DPKGDATADIR=\"/usr/share/geany-plugins\" -DLIBDIR=\"/usr/lib/x86_64-linux-gnu\" -DPKGLIBDIR=\"/usr/lib/x86_64-linux-gnu/geany-plugins\" -DGTK -pthread -I/usr/include/geany -I/usr/include/geany/tagmanager -I/usr/include/geany/scintilla -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -Wall -Wimplicit-function-declaration -Wmiss
 ing-parameter-type -Wold-style-declaration -Wpointer-arith -Wshadow -Wundef -Wwrite-strings -pthread -I/usr/include/gtk-2.0 -I/usr/lib/x86_64-linux-gnu/gtk-2.0/include -I/usr/include/gio-unix-2.0/ -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pixman-1 -I/usr/include/libpng12 -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/libpng12 -I/usr/include/pango-1.0 -I/usr/include/harfbuzz -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -c gcb-plugin.c  -fPIC -DPIC -o .libs/git_changebar_la-gcb-plugin.o
gcb-plugin.c: In function 'diff_buf_to_doc':
gcb-plugin.c:659:56: warning: passing argument 9 of 'git_diff_buffers' from incompatible pointer type [-Wincompatible-pointer-types]
                           buf, len, NULL, &opts, NULL, hunk_cb, NULL, payload);
                                                        ^
In file included from /usr/include/git2/checkout.h:12:0,
                 from /usr/include/git2.h:17,
                 from gcb-plugin.c:29:
/usr/include/git2/diff.h:1113:17: note: expected 'git_diff_binary_cb {aka int (*)(const struct <anonymous> *, const struct <anonymous> *, void *)}' but argument is of type 'git_diff_hunk_cb {aka int (*)(const struct <anonymous> *, const struct <anonymous> *, void *)}'
 GIT_EXTERN(int) git_diff_buffers(
                 ^
gcb-plugin.c:658:9: error: too few arguments to function 'git_diff_buffers'
   ret = git_diff_buffers (old_buf->ptr, old_buf->size, NULL,
         ^
In file included from /usr/include/git2/checkout.h:12:0,
                 from /usr/include/git2.h:17,
                 from gcb-plugin.c:29:
/usr/include/git2/diff.h:1113:17: note: declared here
 GIT_EXTERN(int) git_diff_buffers(
                 ^
make[4]: *** [git_changebar_la-gcb-plugin.lo] Error 1
Makefile:620: recipe for target 'git_changebar_la-gcb-plugin.lo' failed
make[4]: Leaving directory '/«BUILDDIR»/geany-plugins-1.25+dfsg/git-changebar/src'
make[3]: *** [all-recursive] Error 1
make[2]: *** [all-recursive] Error 1
Makefile:579: recipe for target 'all-recursive' failed
make[3]: Leaving directory '/«BUILDDIR»/geany-plugins-1.25+dfsg/git-changebar'
Makefile:624: recipe for target 'all-recursive' failed
make[2]: Leaving directory '/«BUILDDIR»/geany-plugins-1.25+dfsg'
make[1]: *** [all] Error 2
dh_auto_build: make -j4 returned exit code 2
Makefile:556: recipe for target 'all' failed
make[1]: Leaving directory '/«BUILDDIR»/geany-plugins-1.25+dfsg'
make: *** [build-arch] Error 2
debian/rules:98: recipe for target 'build-arch' failed


The full logs are available from 
https://buildd.debian.org/status/package.php?p=geany-plugins


Andreas