[Pkg-giraffe-discuss] Apache configuration

Guido Günther agx at sigxcpu.org
Wed Apr 29 06:52:52 UTC 2015


On Tue, Apr 28, 2015 at 10:22:06PM +0200, Matthias Geerdsen wrote:
> Hi,
> 
> On 04/28/2015 06:49 PM, Guido Günther wrote:
> > Hi Matthias,
> > you started to bring back the configuration for webaccess which we did
> > for 7.1 last year to 7.2. Any chance I can already pull this in?
> 
> actually all that I had done already has been merged into your github
> repo already ( 18b03319627ea7861d5a5f4b9c2ee85691f21649 ,
> 4a0019f1cb4fd7f061feb4ca2cc3ae69cbcc8611 ,
> 8de8e76b1d076a519c1bd88be8b6c80297c94afc)
> Might not be the most elegant stuff, but a first step.

...and I already had cherry picked these a couple of days ago from your
repo but what confused me is that we

* still don't handle any errors (except for the apache helpers you added)
* we don't check $1 so we always run the code not only if $1 == configure
* We replace things in a cfgfile without even giving the user a notice
* We create symlinks that should actually be in the package - any reason
  why this is done in prerm/postinst?

We pulled this in from upstream but need to fix these up as well before
any possible upload.

I've added a "set -e" so we at least fall apart on errors (given that
crypto keys get generated there this won't hurt).

Cheers,
 -- Guido




More information about the Pkg-giraffe-discuss mailing list