[Pkg-giraffe-discuss] zarafa-webaccess, rework of the packaging for Debian
Jelle van der Waa
j.vanderwaa at zarafa.com
Sat May 16 14:11:43 UTC 2015
Hi all,
> So we don't need this code in php5 > 5.2 [1] ?
>
> Can we could simply drop it or don't you detect PHP versions
> having json_encode/json_decode yet?
We can actually just remove the PEAR/JSON.php includes since that file defines json_encode/json_decode if it's not found, see the attached patch.
The PEAR XML parser is still required for the plugin system, to remove this we have to rewrite the parsing of the plugin's manifest files, which will cost a lot of effort.
Jelle
>
> Cheers,
> -- Guido
>
> >
> > >
> > > > E: zarafa-webapp source: source-is-missing client/jquery/jquery-1.6.2.min.js
> >
> > I guess this will be fixed by symlinking to the libjs-jquery package? Should we also ship the non-minified jquery version to follow the debian guidelines? (Easy fix for us to make)
> >
> > > > E: zarafa-webapp source: source-is-missing plugins/files/resources/flash/player.swf
> >
> > Yeah, I'd rather see this removed, if I recall correctly it's used for the files plugin to play files. But since it's also a security risk I rather see it removed I think removing it is harmless. (I will create a ticket in our internal tracker)
> >
> > > > E: zarafa-webapp source: source-is-missing client/tinymce/plugins/media/moxieplayer.swf
> >
> > > > E: zarafa-webapp source: source-is-missing tools/resources/ext-doc/template/ext/resources/ext-base.js
> > > > E: zarafa-webapp source: source-is-missing tools/resources/ext-doc/template/ext/resources/ext-all.js
> > > > E: zarafa-webapp source: source-is-missing tools/resources/ext-doc/template/dot/resources/ext-base.js
> > > > E: zarafa-webapp source: source-is-missing tools/resources/ext-doc/template/dot/resources/ext-all.js
> > > > E: zarafa-webapp source: source-is-missing tools/resources/ext-doc/template/ext/resources/prettify/prettify.js
> > > > E: zarafa-webapp source: source-is-missing tools/resources/ext-doc/template/dot/resources/prettify/prettify.js
> >
> > Yup these tools are not required to run the webapp, can be removed.
> >
> > > > X: zarafa-webapp-files: privacy-breach-generic usr/share/zarafa-webapp/plugins/files/js/external/uxmediapak.js (http://go2.microsoft.com/fwlink/?linkid=108181)
> >
> > I think this is related to movieplayer.swf.
> >
> > > > E: zarafa-webapp-facebook: privacy-breach-facebook usr/share/zarafa-webapp/plugins/facebook/js/facebook.js
> > >
> > > Currently I don't know exactly how to handle this error. Lintian is
> > > suggesting to remove all external calls to Facebook. But then the plug
> > > in will be useless. ;)
> > > Should this package go to non-free (don't know if this is simply
> > > possible) or completely dropping this package?
> >
> > I don't think this plugin still works, so I would suggest to not package it, same for twidget.
> >
> > I hope I've answered some of your open questions!
> >
> > Jelle
> >
> > _______________________________________________
> > Pkg-giraffe-discuss mailing list
> > Pkg-giraffe-discuss at lists.alioth.debian.org
> > http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-giraffe-discuss
> >
>
> [1] http://php.net/manual/en/function.json-decode.php
>
> _______________________________________________
> Pkg-giraffe-discuss mailing list
> Pkg-giraffe-discuss at lists.alioth.debian.org
> http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-giraffe-discuss
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_pear_json_simple.patch
Type: text/x-patch
Size: 881 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/pkg-giraffe-discuss/attachments/20150516/715b34a3/attachment.bin>
More information about the Pkg-giraffe-discuss
mailing list