[Pkg-giraffe-discuss] zarafa-7.2.1 RC1 released

[Guido Günther]

Hi,
On Thu, Aug 20, 2015 at 12:12:07PM +0200, Guido Günther wrote:
> Hi,
> On Thu, Aug 20, 2015 at 11:52:18AM +0200, Mark Dufour wrote:
> [..snip..]
> > sure. please let us know when our help would be required or useful. I'm personally happy to look into anything you point me to.
> > 
> > I guess after 7.2.1-final we'd like to look at all the patches to our ZCP-tree you are still left with, and try to merge them for 7.2.2 where that makes sense.
> 
> Yeah, from what I've seen we're mostly set for an upload to
> experimental. The single thing we should beforehand is letting
> the daemon run as a regular user than root. I'll try to find
> the time to tackle this with Carsten during debconf.

While none of these are really, really bad we should consider cleaning
them up before we upload the first time:

Libraries
=========

$ grep "Package: lib" debian/control | wc -l
14

That's a lot for a groupware. I wonder if we couldn't just bundle them
in one library package for the time being? Especially things like
libzcp_common_ssl seem to only have one single class:

# objdump -w --dynamic-syms /usr/lib/libzcp_common_ssl.so.0.0.0 | grep " g "| grep ECC | wc -l
33

Bundling things would certainly make the ftp-masters happy. We could
also split into three: client, server and common. Opinions?


Recommends
==========
* We currently only suggest a database server so it doesn't get pulled in
  when doing a "apt-get install zarafa-server"
  I think we should recommend mariadb-server so the user gets a working
  installation. If he doesn't want it he an always install without it or
  move it to a different server later. If there's agreement I'll fix this
  in git.

* We don't recommend zarafa-webapp either. o.k. to add this as
  Recommends to the zarafa package? (until we have the webapp in the
  archive and then make it a dependency).

Any opnions on this one?


Poor error handling on wrong permissions
========================================
Doing a

   # zarafa-server -F -c /etc/zarafa/server.cfg && echo "Success."
   Success.

but the daemon is _not_ running due to a:

   pid 19928] mkdir("/var/lib/zarafa/attachments", 0700) = -1 EACCES (Permission denied)
   [pid 19928] open("/var/lib/zarafa/attachments/testfile", O_WRONLY|O_CREAT|O_TRUNC, 0666) = -1 EACCES (Permission denied)
   [pid 19928] write(3, "Sat Sep 12 20:03:00 2015: [error"..., 180) = 180

so it writes to the log nicely but doesn't exit with status 1 making it
impossible for the init system to report the error to the user. The same
is true if the database password is wrong. Log file is o.k. but init
script reports server started although it's not running.

I've applied the attached patch to the Debian package which at least
makes the -F case work as expected. I've not fixed the forking case
yet.

I' also worked around the permission problem in
/etc/init.d/zarafa-server for the time being:

    http://anonscm.debian.org/cgit/pkg-giraffe/giraffe.git/commit/?id=878012959c7ee186d4ed0ce823894d98ff250655


Documentation in /usr/share/doc/zarafa
======================================
The folder currently contains little documentation but lots of
scripts. Iff we want to ship them they should go to
/usr/share/doc/zarafa-server/examples but most of this is of little use
to Debian users. All files need to be moved to
/usr/share/doc/zarafa-server/ since that's the package that ships it.
We can ship a symlink /u/s/doc/zarafa -> zarafa-server if wanted.


Manpages
========
At least the zarafa-server manpages talks about license keys. I don't
think that is applicable for the server (or is it)? If not we should
remove it.


dbconfig-common
===============
There are issues like

Unpacking zarafa-server (7.2.1~RC51272-1~1.gbpdd4839) over (7.2.1~RC51272-1~1.gbpdd4839) ...
/var/lib/dpkg/info/zarafa-server.postrm: 275: /var/lib/dpkg/info/zarafa-server.postrm: db_get: not found
/var/lib/dpkg/info/zarafa-server.postrm: 276: /var/lib/dpkg/info/zarafa-server.postrm: db_reset: not found

when upgrading packags. I'll have a look at these.


Handling of security updates
============================
With the LTS team in Debian we now support packages for 5 years. It's
always a pity if we have to end security support before that due to
lack of upstream support. So I wonder: once we have a version in a
Debian stable release will zarafa support the security team in
backporting fixes to these versions?


zarafa-search
=============
If there are issues running as non root in 7.2.1 should we skip it for
the initial upload. We can easily readd it once the dust has settled
(once we're through the NEW queue).


I'd be happy to pick up on these tasks but wanted to check first if
anybody does similar stuff and get agreement on the library split.

I'm sure some more things will pop up when doing further testing but I
think we're almost there for zcp.

Cheers,
 -- Guido