[Pkg-giraffe-discuss] zarafa-7.2.1 RC1 released

[Guido Günther]

On Mon, Sep 14, 2015 at 11:37:59AM +0200, Mark Dufour wrote:
> hi guido,
> 
>  
> > > I've applied the attached patch to the Debian package which at least
> > > makes the -F case work as expected. I've not fixed the forking case
> > > yet.
> > 
> > This time with patch attached. Would be nice to have this in 7.2.1 if it
> > looks o.k.
> 
> awesome you are patching the code! ^^ and it saves some lines of code, which is always nice..
> 
> but I have to say that I don't see the difference before and after the patch..? every 'goto exit' would set retval to -1, so I fail to see when the function would return 0 in an error situation..?

There were situations were the code did not set retval = -1 e.g. when it
couldn't write to the attachment dir:

Line +1379 in ECServer.cpp:

      // check attachment database started with, and maybe reject startup
      er = check_database_attachments(lpDatabase);
      if (er != erSuccess)
              goto exit;

so the server exited with exit code zero although it didn't start up in
any way. I could have fixed this and several more locations but this way
we return -1 on every error and only 0 if we _really_ managed to get to
the main loop.

Cheers,
 -- Guido