[Pkg-giraffe-discuss] openssl segfault fix

Carsten Schoenert c.schoenert at t-online.de
Tue Jan 10 18:03:39 UTC 2017


Hello Mark,

On 10.01.2017 13:14, Mark Dufour wrote:
> hi guys,
> 
> jan fixed the segfault issue, at least for kopano-admin. it fixes
> the segfault on exit for kopano-admin for me, at least:
> 
> diff --git a/common/SSLUtil.cpp b/common/SSLUtil.cpp
> index 3daf50a1..c22cad9f 100644
> --- a/common/SSLUtil.cpp
> +++ b/common/SSLUtil.cpp
> @@ -82,7 +82,6 @@ void SSL_library_cleanup()
>  
>         CONF_modules_unload(0);
>  
> -       sk_SSL_COMP_free(SSL_COMP_get_compression_methods());
>  }
> 
> it also makes sense as according to jan, sk_SSL_COMP_free is undocumented.

I tried the last days also to dig into the issue, but I was miles away
from seeing the reason of the segfault. I will try this fix later on the
next days.

> I will try to prepare a search-plus renaming patch this week as well. 

Yes, please do.

> what about the minor copy-paste fragments in
> swig/python/kopano/kopano/__init__.py.. we should probably attribute
> these as well in the copyright file? happy to do that as well.

I already did this and pushed to the git archive.

https://anonscm.debian.org/cgit/pkg-giraffe/giraffe.git/commit/?id=e6170d3cb0ec4e9543297c39ad86ff8ee9af712a

-- 
Regards
Carsten Schoenert



More information about the Pkg-giraffe-discuss mailing list