[Pkg-giraffe-discuss] preparations for kopanocore 8.3.x (or 8.4.x)
Carsten Schoenert
c.schoenert at t-online.de
Fri Jul 28 13:46:27 UTC 2017
Hello Mark,
Am 27.07.2017 um 11:46 schrieb Mark Dufour:
> hi carsten,
>
> had a look at the current patch set.
>
> so I just made PR's against 8.5 for the following ones:
>
> Be-pessimistic-about-daemon-startup.patch
> typofix-small-fix-up-for-missspelled-another.patch
> bash-completion-remove-shebang-from-file.patch (not sure I understand this one?)
files that includes commands and functions for the bash-completion
shouldn't have a shebang. The file is always sourced and not executed.
So it doesn't hurt and is even more save if the bash-completion
script(s) doesn't have a shebang.
Lintian is complaining about files with #! sequence that aren't
executable. So the bash-completion snippet doesn't have to be executable
and by that doesn't need a shebang.
> I guess the following one can just be removed at this point?
>
> build-support-gsoap-2.8.36.patch
This is/was related to the guys that use the kopanocore/giraffe packages
in Ubuntu as far I remember. They requested this patch in the past I
guess. But we can drop this due the massive changes in the source and
see what's needed afterwards.
> I've never really seen the following issue.. how often does it occur
> you think?
>
> adding-.NOTPARALLEL-target-to-swig-python-Makefiel.am.patch
In the past (last year) we had some problems with enabled parallel build
of zarafa and this patch is probably just a left over. We can drop it
for now.
I've done some builds now without that patch and all went fine.
> this one I have no clue about, as it's about PHP:
>
> adjust-search-path-for-php-config-script-on-php7.0.patch
Jelle has made a good point later in this thread, we can drop this and
use a addition to the configure call. Sometimes it's better to go
through the autotools related files to understand their full meaning. ;)
And curiously enough we already use this extra configure switch for
selecting the correct php-cli binary so we really don't need that patch.
> I guess the discussion is still ongoing about this one:
>
> Don-t-redefine-__FD_SETSIZE.patch
>
> do you know why or if the following still needed? (default should
> also be kopano? possibly just an issue with 8.1?)
>
> Run-deamons-as-user-group-kopano.patch
To this both points I can't say much how much is needed or obsolete.
I'll rework the patch queue and will pull my changes to Alioth.
--
Regards
Carsten Schoenert
More information about the Pkg-giraffe-discuss
mailing list