[Pkg-giraffe-discuss] kopano-webapp-plugin-files: various license information

[Carsten Schoenert]

Hi,

I guess I've figured out how to get rid of the shipped sabredav stuff.
At least I have symlinked two folders to /usr/share/php/Sabre with a
additional added dependency on php-sabre-{dav,vobject}. See below.

Am 30.09.2017 um 16:14 schrieb Guido Günther:
> Hi,
> On Sat, Sep 30, 2017 at 03:05:00PM +0200, Carsten Schoenert wrote:
>> Hello Jelle,
>>
>> the technical packaging for kopano-webapp-plugin-files is mostly done.
>>
>> Let's move over to the nice parts while doing packaging stuff,
>> collecting all the information for the copyright file. :-)
>>
>> The Kopano stuff is clear, but within the php/ folder I still try to
>> collect all together. The version of sabre-dav Debian is shipping in
>> unstable/testing right now doesn't match the folder structure in the
>> source, I guess the version in Debian is newer?
>> What version of sabre-dav is Kopano using and would it be possible to
>> add such information inside the source in one of the next versions? By
>> this we can always blame Kopano if there is something not clear. :P
>>
>> What about the other files until php/Files/Backend/Webdav, which license
>> have the files and what is known about the copyright holder(s)?
>> Unfortunately no information about that is visible inside the files.
>> That's probably a thing the ftpmasters what to have clear. If the files
>> in question are from Kopano please add some information about the
>> license and the copyright holders inside the head of the files.
> 
> As discussed on #kcon17 please don't ship an embedded copy of
> sabredav. We have 3.1 (experimental), 2.8 (testing/unstable/stable) and
> 1.8 (oldstable) in Debian, one of them should fit.

I played a bit around and I've taken now the versions from
unstable/testing and kopano-webapp is still working. There is also
php-sabre-dav2.1 which probably also can be used.
I was needed to create a small testing WebDav instance to check the
WebDav functionality inside k-w-p-f.

I like to stay on php-sabre-{dav,vobject}. Do we really need the vobject
stuff? The package description says "library to parse and manipulate
iCalendar and vCard objects" there this isn't really needed for files,
isn't it? I didn't discovered any problems right now if I remove the
vobject folder.

We should no matter how add some autopkgtests to check if the php
functions are available and usable, the php packages may chnage over
time. But this needs someone with enough PHP knowledge, Jelle can you
please show some basic practical test for this?

BTW: I wasn't able to get a working webdav setup for k-w-p-f if I
enforce a digest authentication inside Apache, only if "AuthType Basic"
is used the files plugin was working.
If we could expand the autopkgtests one day to include such testing also
would be great.


>>> $ tree php/ -d
>>> php/
>>> ├── Files  <--- Kopano?
>>> │   ├── Backend  <--- Kopano?
>>> │   │   ├── FTP  <--- Kopano?
>>> │   │   │   └── css  <--- Kopano?
>>> │   │   └── Webdav <--- Kopano?
>>> │   │       ├── css  <--- Kopano?
>>> │   │       └── sabredav
>>> │   │           └── vendor
>>> │   │               ├── composer  <--- Kopano?
>>> │   │               └── sabre   <--- sabre-dav version?
>>> │   │                   ├── dav
>>> │   │                   │   ├── bin  <--- deleted
>>> │   │                   │   ├── examples  <--- deleted
>>> │   │                   │   ├── lib 
>>> │   │                   │   │   └── Sabre   <---- linked to /usr/share/php/Sabre
...
>>> │   │                   │   └── tests  <--- deleted
>>> │   │                   └── vobject
>>> │   │                       ├── bin  <--- deleted
>>> │   │                       ├── lib
>>> │   │                       │   └── Sabre   <---- linked to /usr/share/php/Sabre
>>> │   │                       └── tests  <--- deleted
>>> │   └── Core <--- Kopano?
>>> │       └── Util  <--- Kopano?
>>> └── lib
>>>     └── phpfastcache
Jelle, can you please say something about the licensing to the folders
I've marked.

So now I can prepare a new import from scratch with the additional
folders to delete:

 php/Files/Backend/Webdav/sabredav/vendor/sabre/dav
 php/Files/Backend/Webdav/sabredav/vendor/sabre/vobject

Afterwards I will create a new git repository on Alioth and the
respective ITP for kopano-webapp-plugins-files.

-- 
Regards
Carsten Schoenert