[Pkg-giraffe-discuss] kopano-webapp and PHP 7.1

[Jelle van der Waa]

> after pulling the changes the Ubuntu people have done on kopanocore I
> tried to play around with bumping PHP version to 7.1. So I have build
> the current 8.5.0 pre-version against php7.1-dev (php-mapi)
> 
> After fighting a bit with the php packages for getting the needed
> modules installed and activated I can't see now the kopano-webapp site
> anymore after login due critical PHP errors.
> 
> > [Thu Dec 21 18:22:22.775763 2017] [php7:error] [pid 14260] [client 192.168.122.1:33750] PHP Fatal error:  Uncaught Error: Class 'SimpleXMLElement' not found in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php:849\nStack trace:\n#0 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(417): PluginManager->extractPluginDataFromXML('<?xml version="...', 'files')\n#1 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(211): PluginManager->processPlugin('files')\n#2 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(164): PluginManager->readPluginFolder(Array)\n#3 /usr/share/kopano-webapp/index.php(167): PluginManager->detectPlugins('')\n#4 {main}\n  thrown in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php on line 849, referer: https://192.168.122.43/webapp/
> > [Thu Dec 21 18:22:34.970843 2017] [php7:error] [pid 14256] [client 192.168.122.1:33764] PHP Fatal error:  Uncaught Error: Class 'SimpleXMLElement' not found in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php:849\nStack trace:\n#0 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(417): PluginManager->extractPluginDataFromXML('<?xml version="...', 'files')\n#1 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(211): PluginManager->processPlugin('files')\n#2 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(164): PluginManager->readPluginFolder(Array)\n#3 /usr/share/kopano-webapp/index.php(167): PluginManager->detectPlugins('')\n#4 {main}\n  thrown in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php on line 849, referer: https://192.168.122.43/webapp/
> > [Thu Dec 21 18:22:49.544871 2017] [php7:error] [pid 14261] [client 192.168.122.1:33772] PHP Fatal error:  Uncaught Error: Class 'SimpleXMLElement' not found in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php:849\nStack trace:\n#0 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(417): PluginManager->extractPluginDataFromXML('<?xml version="...', 'files')\n#1 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(211): PluginManager->processPlugin('files')\n#2 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(164): PluginManager->readPluginFolder(Array)\n#3 /usr/share/kopano-webapp/index.php(167): PluginManager->detectPlugins('')\n#4 {main}\n  thrown in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php on line 849, referer: https://192.168.122.43/webapp/?user=foo
> > [Thu Dec 21 18:22:52.704896 2017] [php7:error] [pid 14263] [client 192.168.122.1:33774] PHP Fatal error:  Uncaught Error: Class 'SimpleXMLElement' not found in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php:849\nStack trace:\n#0 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(417): PluginManager->extractPluginDataFromXML('<?xml version="...', 'files')\n#1 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(211): PluginManager->processPlugin('files')\n#2 /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php(164): PluginManager->readPluginFolder(Array)\n#3 /usr/share/kopano-webapp/index.php(167): PluginManager->detectPlugins('')\n#4 {main}\n  thrown in /usr/share/kopano-webapp/server/includes/core/class.pluginmanager.php on line 849, referer: https://192.168.122.43/webapp/?user=foo
> 
> 
> I'm definitely no PHP expert and maybe there is also some dependency for
> the PHP7.1 stuff in Debian unstable not correct. After installing
> php7.1-xml the webapp is working again (I assume).

Yup we have required php-xml for a long time. I guess it was split up from php-common or php later.

> Given that php7.0 is currently still the default in unstable I'm in
> favor for staying on PHP 7.0 also for kopanocore and kopano-webapp and
> using the (*)php-foo packages within the dependencies.

Fine by me, 7.1 doesn't offer that many benefits but our code is compatible with 7.1 since 3.4?? Or an older release.
I'm running our WebApp with PHP 7.2 which required no code changes.
 
 
> I guess upstream has no strong objection on moving to PHP 7.1 quickly
> due needed supporting also older versions of PHP.
> 
> On then other side, the webapp 3.4.1 is also working the the current
> kopanocore snapshot 8.5.0. That encourages me that the current state in
> debian/experimental could be given a try in experimental or I can push
> my work to Alioth at least. This would including most of the
> modifications that Ubuntu has done on top of the 8.3.4-4.
> 
> If I can figure also out what are still needed in the webapp package I
> would also prepare the 3.4.1 for uploading. So far I remember from the
> last weekend it was just a little thing ...

Latest release is now 3.4.2 :)

Oh and I noticed that Kopano-webapp is checked if it's reproducible now :)

https://tests.reproducible-builds.org/debian/rb-pkg/experimental/amd64/kopano-webapp.html

I'll check if this is easily fixable, but I fear it requires changes in the closure-compiler.