[Pkg-giraffe-discuss] Getting autopkgtest for kopanocore working (finally)

[Guido Günther]

Hi,
Yay, progress! Great you nailed it down. We're quite close to an upload
now it seems!

On Sat, Dec 15, 2018 at 05:17:51PM +0100, Carsten Schoenert wrote:
[..snip..]
> If I add mariadb-server to the Depends of the first autopkgtest all is
> working without the need of any tweeks in the smoke script. Hmm, that
> is

You didn't provide the full log but something is really wrong here: The
test was specifically written to test the correct order of getting the
db up. I'm looking at revision 875be0f72 since it's a bit shorter:

----
echo "Installing database and server packages..."
apt-get -y install mariadb-server
/etc/init.d/mysql start
apt-get -y install kopano-server kopano-utils
echo "done."
---

So there is basically no way that kopano-server can get installed
without mariadb-server being installed first.

> obviously not what we want to have. But a dpkg-reconfigure of the
> package kopano-server after the installation of mariadb-server is doing
> the trick and the autopkg thingy is working like before!
> 
> Any other objections or suggestion I should consider now before pushing
> all to Salsa? Something I've forgotten?

See above. I think there is no bug here, your test setup is broken. You
must not have kopano-server installed when running the tests. See:

   https://github.com/tijuca/Giraffe/blob/debian/sid/debian/tests/control

So we have two choices: 

a) Fail outright at the beginning of the script if kopano-server is installed:

   if dpkg -s kopano-server 2>/dev/null; then
     echo "You must not have kopano-server installed." 1>&2
     exit 1
   fi

b) Do the dpkg-reconfigure to work around broken test setups (but only then).

   if dpkg -s kopano-server 2>/dev/null; then
     echo "kopano-server already installed. Trying to work around that." 1>&2
     KOPANO_SERVER_WA=1
   fi

....

   [ -z "$KOPANO_SERVER_WA" ] || dpkg-reconfigure kopano-server


It'd opt for a) since if we allow for that we still have problems of
prefilled databases, etc. so we should always cater for a clean testbed.
Does this make sense?

Cheers
 -- Guido

> I'm glad it's that stupid simple in the end!
> I pushed the current tree to GitHub meanwhile.
> 
> https://github.com/tijuca/Giraffe/commits/debian/sid
> 
> [1] https://www.debian.org/doc/manuals/dbconfig-common/dbconfig-common.pdf
> 
> -- 
> Regards
> Carsten Schoenert
> 
> _______________________________________________
> Pkg-giraffe-discuss mailing list
> Pkg-giraffe-discuss at alioth-lists.debian.net
> https://alioth-lists.debian.net/cgi-bin/mailman/listinfo/pkg-giraffe-discuss