[Pkg-gmagick-im-team] [Pkg-gmagick-svn-commit] r50 - branches/6.3.9.4.dfsg1-1/debian

[Daniel Kobras]

Hi!

On Thu, Mar 27, 2008 at 06:26:07PM -0300, Nelson A. de Oliveira wrote:
> On Thu, Mar 27, 2008 at 5:27 PM, Daniel Kobras <kobras at debian.org> wrote:
> >  'make LD_RUN_PATH=' is the trick to get rid of the RPATH in the Perl
> >  module without the chrpath hack.
> 
> Do both solutions have the same result?

I'm not sure, but comparing the ELF headers of old and new Perl modules
should give a definitive answer. I'd expect them to be similar, though.

> Current: DESTDIR=$(CURDIR)/debian/tmp
> New: DESTDIR="$(CURDIR)"/debian/tmp or it's better
> DESTDIR="$(CURDIR)/debian/tmp" ?

Both forms are equal. We ought to quota all path we don't have full
control over. The rest can be left as is.

> Then where using DESTDIR:
> PREFIX=$(DESTDIR)/usr
> Is it necessary to quote it too? (becoming PREFIX="$(DESTDIR)"/usr, for example)

The variables need to be quoted whenever they are passed to the shell,
ie.

DESTDIR=$(CURDIR)/debian/tmp

but

install:
	$(MAKE) DESTDIR="$(DESTDIR)"

or (stupid example)

install:
	DESTDIR="$(CURDIR)"/debian/tmp $(MAKE) DESTDIR="$$DESTDIR"

Regards,

Daniel.