[Pkg-gmagick-im-team] [Pkg-gmagick-svn-commit] r50 - branches/6.3.9.4.dfsg1-1/debian

[Daniel Kobras]

On Sat, Mar 22, 2008 at 10:55:55PM +0000, naoliv at alioth.debian.org wrote:
> Include manpages in packages; I am using the same .install file for
> this, but it's also possible to use .manpages files (and call
> dh_installman), but it seems that it would be necessary to add the
> full path inside the .manpages (debian/tmp/usr/share/man/man1/foo.1
> instead usr/share/man/man1/foo.1, as it's now in .install; it's only a
> cosmetic thing to choose, as I can see);

dh_installman runs further checks on the files it acts on, so is
generally preferrable. At the moment, I don't think there's a visible
difference, though.

> @@ -44,11 +40,7 @@
>  	-e 's/^hardcode_libdir_flag_spec.*$$/hardcode_libdir_flag_spec=" -D__LIBTOOL_IS_A_FOOL__ "/' \
>  	-e '/^archive_cmds="/s/"$$/ \\$$deplibs"/' 
>  
> -	# Add here commands to compile the package.
> -
>  	$(MAKE) 
> -#	cd $(CURDIR)/PerlMagick && perl Makefile.PL
> -#	cd $(CURDIR)/PerlMagick && make LD_RUN_PATH=
>  
>  	touch build-stamp
>  

'make LD_RUN_PATH=' is the trick to get rid of the RPATH in the Perl
module without the chrpath hack.

>  	# Fix HTML location inside manpages
>  	sed -i 's/doc\/ImageMagick-$(IMAGEMAGICKVERSION)/doc\/imagemagick/' \
> -		"$(CURDIR)"/debian/tmp/usr/share/man/man1/*
> +		$(CURDIR)/debian/tmp/usr/share/man/man1/*

That's a step backwards as it breaks when building the package in, say,
'/tmp/Image Magick/'. I think we'd better add consistent quotes
throughout debian/rules as a whole.

Regards,

Daniel.