[Pkg-gmagick-im-team] RFS: raqm/0.3.0-1 [NEW]

[Emilio Pozuelo Monfort]

On 28/10/17 04:48, أحمد المحمودي wrote:
> Hello,
> 
> On Thu, Oct 26, 2017 at 09:51:59AM +0200, Emilio Pozuelo Monfort wrote:
>> The package looks quite good. The test suite is failing for me in a chroot (C
>> locale), setting the locale to C.UTF-8 fixes it. I've pushed a fix for that.
>>
>> The gtk-doc stuff need a doc-base file, i.e. debian/libraqm-dev.doc-base. See
>> e.g. src:pango1.0 for an example. That helps tools find the documentation, e.g.
>> the devhelp doc viewer. I have added one.
> 
> Thanks
> 
>> BTW like upstream, I'm not convinced that patch is correct. You should use
>> PRIu32 for int32_t, not %zu.
> 
> I don't understand this part. Anyways upstream did accept the patch. The reason
> for the patch is to avoid FTBFS on i386 arch.

See
https://stackoverflow.com/questions/12120426/how-to-print-uint32-t-and-uint16-t-variables-value#12120500

Basically, the format definition varies across architectures, so you need to use
that define in order to get the right format for each architecture. That will
fix it on i386 as well as in others, without causing regressions e.g. on amd64.

Cheers,
Emilio