[Pkg-gmagick-im-team] Bug#921134: imagemagick-6.q16: convert .ico regression: InvalidImageIndex subimage specification returns no images

[Phil Morrell]

Package: imagemagick-6.q16
Version: 8:6.9.10.23+dfsg-1
Severity: normal
Tags: upstream

Hi,

An upstream change in 6.9.10-16 appears to have broken frame indexing syntax,
as used in corsix-th within an icon size loop (#919083 FTBFS):

https://github.com/ImageMagick/ImageMagick6/commit/02023b057fbceb60df963612d42bab2f311de67b

convert-im6.q16 ico:CorsixTH.ico[2] corsix-th.png

I've attached the sample .ico in case it is malformed in some way, and the
output of the above reproduction test in fresh sid and stretch chroots with
-dbgsym, as per the reportbug recommendations.
--
Phil Morrell (emorrp1)


``` # sid
root at olorin:/# identify-im6.q16 ico:CorsixTH.ico
ico:CorsixTH.ico=>CorsixTH.ico[0] PNG 256x256 256x256+0+0 8-bit sRGB 32004B 0.000u 0:00.009
ico:CorsixTH.ico=>CorsixTH.ico[1] ICO 128x128 128x128+0+0 8-bit sRGB 0.000u 0:00.009
ico:CorsixTH.ico=>CorsixTH.ico[2] ICO 64x64 64x64+0+0 8-bit sRGB 0.000u 0:00.000
ico:CorsixTH.ico=>CorsixTH.ico[3] ICO 48x48 48x48+0+0 8-bit sRGB 0.000u 0:00.000
ico:CorsixTH.ico=>CorsixTH.ico[4] ICO 32x32 32x32+0+0 8-bit sRGB 0.000u 0:00.000
ico:CorsixTH.ico=>CorsixTH.ico[5] ICO 24x24 24x24+0+0 8-bit sRGB 0.000u 0:00.000
ico:CorsixTH.ico=>CorsixTH.ico[6] ICO 16x16 16x16+0+0 8-bit sRGB 134138B 0.000u 0:00.000
root at olorin:/# convert-im6.q16 -verbose ico:CorsixTH.ico[2] corsix-th.png
PNG:CorsixTH.ico=>CorsixTH.ico PNG 256x256 256x256+0+0 8-bit sRGB 32004B 0.010u 0:00.000
ico:CorsixTH.ico[2]=>CorsixTH.ico[2] ICO 64x64 64x64+0+0 8-bit sRGB 134138B 0.000u 0:00.000
ico:CorsixTH.ico[2]=>corsix-th.png[2] ICO 64x64 64x64+0+0 8-bit sRGB 3947B 0.010u 0:00.019
convert-im6.q16: InvalidImageIndex `CorsixTH.ico' @ error/list.c/CloneImages/281. 
convert-im6.q16: subimage specification returns no images `CorsixTH.ico' @ error/constitute.c/ReadImage/642.
```

``` # stretch
root at olorin:/# identify-im6.q16 ico:CorsixTH.ico
ico:CorsixTH.ico=>CorsixTH.ico[0] PNG 256x256 256x256+0+0 8-bit sRGB 134KB 0.000u 0:00.010
ico:CorsixTH.ico=>CorsixTH.ico[1] ICO 128x128 128x128+0+0 32-bit sRGB 134KB 0.000u 0:00.010
ico:CorsixTH.ico=>CorsixTH.ico[2] ICO 64x64 64x64+0+0 32-bit sRGB 134KB 0.000u 0:00.010
ico:CorsixTH.ico=>CorsixTH.ico[3] ICO 48x48 48x48+0+0 32-bit sRGB 134KB 0.000u 0:00.010
ico:CorsixTH.ico=>CorsixTH.ico[4] ICO 32x32 32x32+0+0 32-bit sRGB 134KB 0.000u 0:00.010
ico:CorsixTH.ico=>CorsixTH.ico[5] ICO 24x24 24x24+0+0 32-bit sRGB 134KB 0.000u 0:00.010
ico:CorsixTH.ico=>CorsixTH.ico[6] ICO 16x16 16x16+0+0 32-bit sRGB 134KB 0.000u 0:00.010
root at olorin:/# convert-im6.q16 -verbose ico:CorsixTH.ico[2] corsix-th.png
CorsixTH.ico PNG 256x256 256x256+0+0 8-bit sRGB 32KB 0.000u 0:00.000
ico:CorsixTH.ico[2]=>CorsixTH.ico[2] ICO 64x64 64x64+0+0 32-bit sRGB 0.000u 0:00.000
ico:CorsixTH.ico[2]=>corsix-th.png[2] ICO 64x64 64x64+0+0 8-bit sRGB 3.95KB 0.000u 0:00.000
```
-------------- next part --------------
A non-text attachment was scrubbed...
Name: CorsixTH.ico
Type: image/vnd.microsoft.icon
Size: 134138 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gmagick-im-team/attachments/20190202/51afe618/attachment-0001.ico>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: corsix-th.png
Type: image/png
Size: 3947 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gmagick-im-team/attachments/20190202/51afe618/attachment-0001.png>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gmagick-im-team/attachments/20190202/51afe618/attachment-0001.sig>