[Pkg-gmagick-im-team] imagemagick 7 needs cmake adjustments?

[Bastien Roucariès]

Le jeudi 31 octobre 2024, 13:41:55 UTC Steven Robbins a écrit :
> Hello,
> 
> I got a note that digikam failed to build with new imagemagick 7.  The specific 
> error was that including <Magick++/Include.h> failed:
> 
> In file included from /usr/include/ImageMagick-7/Magick++/Include.h:16,
>                  from /usr/include/ImageMagick-7/Magick++.h:12,
>                  from /<<PKGBUILDDIR>>/core/libs/dialogs/libsinfodlg.cpp:77:
> /usr/include/ImageMagick-7/MagickCore/magick-config.h:25:10: fatal error: 
> MagickCore/magick-baseconfig.h: No such file or directory
>    25 | #include "MagickCore/magick-baseconfig.h"
>       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> compilation terminated.
> 
> This stemmed from a lack of -I directive on the compile line for the 
> architecture-dependent directory.  In previous builds, the cmake config was 
> able to locate two include dirs.  
> 
> -- ImageMagick_INCLUDE_DIRS:           	/usr/include/ImageMagick-6;/usr/
> include/x86_64-linux-gnu/ImageMagick-6
> 
> When building against imagemagick 7, the second one is missing -- which is 
> where "magick-baseconfig.h" is located.
> 
> Ultimately this turns out to be due to a change in imagemagick directory 
> names:
> 
> /usr/include/x86_64-linux-gnu/ImageMagick-6/magick
> /usr/include/x86_64-linux-gnu/ImageMagick-7/MagickCore
> 
> This change forces adaptation in the cmake module because currently it 
> searches for "magick/magick-baseconfig.h" when locating the arch include dir.  
> It's curious that the cmake does have changes already in place for 
> ImageMagick-7, but not for the magick --> MagickCore change.
> 
> The reason for this email is to ask whether this change is indeed from 
> upstream or is it a Debian decision?  If the latter, then would you consider 
> changing back?  Otherwise, heads-up to the cmake team that the module needs 
> changing.

cmake should use if possible pkgconfig, 

If not it is a plain bug

Bastien
> 
> In the case of Digikam, it ships its own cmake module so I fixed my problem 
> there.  See https://salsa.debian.org/debian/digikam/-/commit/
> 92419186b350a92cc70d6810794e5e8a8a180eaa
> 
> -Steve
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: This is a digitally signed message part.
URL: <http://alioth-lists.debian.net/pipermail/pkg-gmagick-im-team/attachments/20241031/3884aa40/attachment.sig>