[Pkg-gnome-extras-maintainers] Bug#1145660: gucharmap: unreadable text due to hardcoded colour

[astian]

Package: gucharmap
Version: 1:17.0.2-2
Severity: minor
Control: tags -1 + patch

Dear Maintainer,

The "annotations and cross-reference" section of the "details" page for
a given character can contain links which, depending on the active
theme, are unreadable or difficult to read because gucharmap hardcodes
the text colour as "blue" (#0000ff).

Hardcoding a foreground colour but not the corresponding background
colour (or viceversa) is braindamaged.

Should use the theme's link colour instead.

Attached is a patch.

Also attached is a patch I needed in order to build with muon.  I'm not
sure if the problem is in gucharmap's meson.build, in meson, or in muon.
I'm also not sure if I fixed it the proper way; but it worked.

Also attached is a patch that fixes a GCC warning is the same function.

-- System Information:
Debian Release: forky/sid
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'unstable'), (500, 'testing'), (500, 'stable')
Architecture: amd64 (x86_64)

Kernel: Linux 6.12.105+deb13-amd64 (SMP w/4 CPU threads; PREEMPT)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages gucharmap depends on:
ii  dconf-gsettings-backend [gsettings-backend]  0.49.0-4+b1
ii  libatk1.0-0t64                               2.61.1-1
ii  libc6                                        2.43-4
ii  libcairo2                                    1.18.4-3+b1
ii  libglib2.0-0t64                              2.89.3-5
ii  libgtk-3-0t64                                3.24.52-1
ii  libgucharmap-2-90-7                          1:17.0.2-2
ii  libpango-1.0-0                               1.58.0-1
ii  libpangocairo-1.0-0                          1.58.0-1

Versions of packages gucharmap recommends:
ii  yelp  49.1-3

gucharmap suggests no packages.

-- no debconf information
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01-fix-building-with-muon.patch
Type: text/x-patch
Size: 701 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-extras-maintainers/attachments/20260826/771b803d/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02-avoid-nul-truncation-warning.patch
Type: text/x-patch
Size: 723 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-extras-maintainers/attachments/20260826/771b803d/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03-dont-hardcode-link-colour.patch
Type: text/x-patch
Size: 1801 bytes
Desc: not available
URL: <http://alioth-lists.debian.net/pipermail/pkg-gnome-extras-maintainers/attachments/20260826/771b803d/attachment-0002.bin>