Bug#185953: marked as done (rhythmbox : lirc volume broken [patch])
Debian Bug Tracking System
owner@bugs.debian.org
Sun, 21 Dec 2003 17:48:17 -0600
Your message dated Sun, 21 Dec 2003 20:05:40 +0100
with message-id <877k0qf0u3.fsf@seb128.wanadoo.fr>
and subject line Bug#185953: rhythmbox : lirc volume broken [patch]
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 23 Mar 2003 09:13:50 +0000
>From vincent.vanackere@cmi.univ-mrs.fr Sun Mar 23 03:13:49 2003
Return-path: <vincent.vanackere@cmi.univ-mrs.fr>
Received: from amarseille-107-1-8-28.abo.wanadoo.fr (diablo) [81.49.79.28]
by master.debian.org with esmtp (Exim 3.12 1 (Debian))
id 18x1Y4-0006pt-00; Sun, 23 Mar 2003 03:13:49 -0600
Received: from vince by diablo with local (Exim 3.36 #1 (Debian))
id 18x1aU-0000Yj-00; Sun, 23 Mar 2003 10:16:18 +0100
Content-Type: multipart/mixed; boundary="===============18874440211110732=="
MIME-Version: 1.0
From: Vincent VANACKERE <vincent.vanackere@cmi.univ-mrs.fr>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: rhythmbox : lirc volume broken [patch]
X-Mailer: reportbug 2.10.1
Date: Sun, 23 Mar 2003 10:16:18 +0100
Message-Id: <E18x1aU-0000Yj-00@diablo>
Delivered-To: submit@bugs.debian.org
X-Spam-Status: No, hits=-1.1 required=4.0
tests=HAS_PACKAGE,PATCH_UNIFIED_DIFF,SPAM_PHRASE_00_01
version=2.44
X-Spam-Level:
This is a multi-part MIME message sent by reportbug.
--===============18874440211110732==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Package: rhythmbox
Version: 0.4.5-6
Severity: normal
Hi, this patch fixes lirc volume up/down in rhythmbox.
BTW: setting the shuffle mode by lirc is broken at the moment
(the button is toggled, with no effect...).
-- System Information:
Debian Release: testing/unstable
Architecture: i386
Kernel: Linux diablo 2.4.21-pre5aa2 #1 Sat Mar 15 12:26:21 CET 2003 i686
Locale: LANG=C, LC_CTYPE=fr_FR.ISO-8859-1
Versions of packages rhythmbox depends on:
ii bonobo-activation 1:2.2.1.1-1 Bonobo Activation Framework
ii gconf2 2.2.0-1 GNOME configuration database syste
ii gstreamer-alsa [gstreamer- 0.6.0-4 ALSA plugin for GStreamer
ii gstreamer-core 0.6.0-1 Core element and library plugins f
ii gstreamer-core-libs 0.6.0-1 Core library plugins for GStreamer
ii gstreamer-gconf 0.6.0-4 GConf support for GStreamer
ii gstreamer-gnomevfs 0.6.0-4 Gnome VFS plugin for GStreamer
ii gstreamer-mad 0.6.0-4 MAD MPEG audio decoder plugin for
ii gstreamer-misc 0.6.0-4 Collection of various GStreamer pl
ii gstreamer-oss [gstreamer-a 0.6.0-4 OSS plugin for GStreamer
ii gstreamer-vorbis 0.6.0-4 Vorbis plugin for GStreamer
ii libart-2.0-2 2.3.11-3 Library of functions for 2D graphi
ii libatk1.0-0 1.2.2-4 The ATK accessibility toolkit
ii libaudiofile0 0.2.3-4 The Audiofile Library
ii libbonobo-activation4 1:2.2.1.1-1 Bonobo Activation Framework -- run
ii libbonobo2-0 2.2.1-1 Bonobo CORBA interfaces library
ii libbonoboui2-0 2.2.0.1-2 The Bonobo UI library
ii libc6 2.3.1-15 GNU C Library: Shared libraries an
ii libesd0 0.2.29-1 Enlightened Sound Daemon - Shared
ii libflac4 1.1.0-3 Free Lossless Audio Codec - runtim
ii libgconf2-4 2.2.0-1 GNOME configuration database syste
ii libgcrypt1 1.1.12-1 LGPL Crypto library - runtime libr
ii libglade2-0 2.0.1-3 Library to load .glade files at ru
ii libglib2.0-0 2.2.1-3 The GLib library of C routines
ii libgnome2-0 2.2.0.1-1 The GNOME 2 library - runtime file
ii libgnomecanvas2-0 2.2.0.2-1 A powerful object-oriented display
ii libgnomeui-0 2.2.0.1-2 The GNOME 2 libraries (User Interf
ii libgnomevfs2-0 2.2.3-2 The GNOME virtual file-system libr
ii libgnutls5 0.8.4-1 GNU TLS library - runtime library
ii libgstreamer0.6-0 0.6.0-1 Core GStreamer shared library
ii libgtk2.0-0 2.2.1-3 The GTK+ graphical user interface
ii libid3tag0 0.14.2b-8 ID3 tag reading library from the M
ii libjpeg62 6b-7 The Independent JPEG Group's JPEG
ii liblinc1 1:1.0.1-1 library to simplify creating netwo
ii liblircclient0 0.6.6-5 LIRC client library
ii libmusicbrainz1c102 1.1.0-3 Second generation incarnation of t
ii libogg0 1.0.0-1 Ogg Bitstream Library
ii liborbit2 1:2.6.0-2 Libraries for ORBit2 - a CORBA ORB
ii libpango1.0-0 1.2.1-3 Layout and rendering of internatio
ii libpopt0 1.6.4-2 lib for parsing cmdline parameters
ii libstdc++5 1:3.2.3-0pre6 The GNU Standard C++ Library v3
ii libtasn1-0 0.1.2-1 Manage ASN.1 structures (runtime)
ii libvorbis0a 1.0.0-3a The Vorbis General Audio Compressi
ii libvorbisfile3 1.0.0-3a The Vorbis General Audio Compressi
ii libxml2 2.5.4-1 GNOME XML library
ii libxosd2 2.1.2-1 X On-Screen Display library - runt
ii scrollkeeper 0.3.12-2 A free electronic cataloging syste
ii vorbis-tools 1.0.0-2 Several Ogg Vorbis Tools
ii xlibs 4.2.1-6 X Window System client libraries
ii zlib1g 1:1.1.4-11 compression library - runtime
-- no debconf information
--===============18874440211110732==
Content-Type: text/x-c; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="/tmp/patch.volume.lirc"
diff -u --recursive rhythmbox-0.4.5-orig/lib/widgets/rb-volume.c rhythmbox-0.4.5/lib/widgets/rb-volume.c
--- rhythmbox-0.4.5-orig/lib/widgets/rb-volume.c 2003-02-09 09:11:37.000000000 +0100
+++ rhythmbox-0.4.5/lib/widgets/rb-volume.c 2003-03-23 09:53:59.000000000 +0100
@@ -352,7 +352,7 @@
return volume;
}
-int
+float
rb_volume_get (RBVolume *volume)
{
g_return_val_if_fail (RB_IS_VOLUME (volume), -1);
@@ -362,7 +362,7 @@
void
rb_volume_set (RBVolume *volume,
- int value)
+ float value)
{
g_return_if_fail (RB_IS_VOLUME (volume));
diff -u --recursive rhythmbox-0.4.5-orig/lib/widgets/rb-volume.h rhythmbox-0.4.5/lib/widgets/rb-volume.h
--- rhythmbox-0.4.5-orig/lib/widgets/rb-volume.h 2003-02-09 09:11:36.000000000 +0100
+++ rhythmbox-0.4.5/lib/widgets/rb-volume.h 2003-03-23 09:54:25.000000000 +0100
@@ -49,9 +49,9 @@
RBVolume *rb_volume_new (MonkeyMediaPlayer *player);
-int rb_volume_get (RBVolume *volume);
+float rb_volume_get (RBVolume *volume);
void rb_volume_set (RBVolume *volume,
- int value);
+ float value);
gboolean rb_volume_get_mute (RBVolume *volume);
void rb_volume_set_mute (RBVolume *volume, gboolean mute);
diff -u --recursive rhythmbox-0.4.5-orig/shell/rb-shell.c rhythmbox-0.4.5/shell/rb-shell.c
--- rhythmbox-0.4.5-orig/shell/rb-shell.c 2003-02-09 09:11:21.000000000 +0100
+++ rhythmbox-0.4.5/shell/rb-shell.c 2003-03-23 09:51:07.000000000 +0100
@@ -2483,7 +2483,7 @@
{
gboolean shuffle;
gboolean repeat;
- int volume;
+ float volume;
gboolean mute;
switch (cmd) {
--===============18874440211110732==--
---------------------------------------
Received: (at 185953-done) by bugs.debian.org; 21 Dec 2003 23:46:24 +0000
>From seb128@debian.org Sun Dec 21 17:46:23 2003
Return-path: <seb128@debian.org>
Received: from smtp5.wanadoo.fr (mwinf0502.wanadoo.fr) [193.252.22.26]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AY8tb-0007s3-00; Sun, 21 Dec 2003 13:05:43 -0600
Received: from seb128 (ANancy-111-1-4-171.w81-250.abo.wanadoo.fr [81.250.112.171])
by mwinf0502.wanadoo.fr (SMTP Server) with ESMTP id BD43DE80039A
for <185953-done@bugs.debian.org>; Sun, 21 Dec 2003 20:05:40 +0100 (CET)
Received: from seb128 by seb128 with local (Exim 3.36 #1 (Debian))
id 1AY8tY-00015W-00
for <185953-done@bugs.debian.org>; Sun, 21 Dec 2003 20:05:40 +0100
To: 185953-done@bugs.debian.org
Subject: Re: Bug#185953: rhythmbox : lirc volume broken [patch]
In-Reply-To: <3FE5E0F8.805@lif.univ-mrs.fr> (Vincent Vanackere's message of
"Sun, 21 Dec 2003 19:05:44 +0100")
References: <87y8t6f7l6.fsf@seb128.wanadoo.fr> <3FE5E0F8.805@lif.univ-mrs.fr>
From: Sebastien Bacher <seb128@debian.org>
X-Mailer: Gnus 5.10.1
Date: Sun, 21 Dec 2003 20:05:40 +0100
Message-ID: <877k0qf0u3.fsf@seb128.wanadoo.fr>
User-Agent: Gnus/5.1002 (Gnus v5.10.2) Emacs/21.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: Sebastien Bacher <seb128@debian.org>
Delivered-To: 185953-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin
2.60-master.debian.org_2003_11_25-bugs.debian.org_2003_12_15
(1.212-2003-09-23-exp) on master.debian.org
X-Spam-Status: No, hits=-1.8 required=4.0 tests=FOOASDF,FROM_ENDS_IN_NUMS,
HAS_BUG_NUMBER autolearn=no
version=2.60-master.debian.org_2003_11_25-bugs.debian.org_2003_12_15
X-Spam-Level:
Vincent Vanackere <vanackere@lif.univ-mrs.fr> writes:
> AFAIK there is not any lirc support code left in the current rhythmbox,
> therefore you can safely close this bug as it is not pertinent any
> more... (Sidenote: I switched back to xmms... waiting until lirc
> support is added back to rhythmbox).
Ok, so bug closed.
Thanks,
Sebastien Bacher