[Bug 109213] Changed - GtkNotebook buttons in labels get highlighted on tab switch

[bugzilla-daemon@widget.gnome.org]

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.

http://bugzilla.gnome.org/show_bug.cgi?id=109213

Changed by sandmann@daimi.au.dk.

--- shadow/109213	Thu Nov 13 17:53:37 2003
+++ shadow/109213.tmp.11419	Thu Nov 13 18:12:49 2003
@@ -9,13 +9,13 @@
 Priority: Normal
 Component: gtk
 AssignedTo: gtk-bugs@gtk.org                            
 ReportedBy: in7y118@public.uni-hamburg.de               
 TargetMilestone: 2.4 API freeze
 URL: 
-Cc: dobey@free.fr,pkg-gnome-maintainers@lists.alioth.debian.org
+Cc: dobey@free.fr
 Summary: GtkNotebook buttons in labels get highlighted on tab switch
 
 Open Galeon.
 Open a second tab.
 Switch from one tab to another (either via mouse or Ctrl-PgUp/PgDown)
 
@@ -71,6 +71,22 @@
 patch would be easily ported to HEAD as well.
 
 ------- Additional Comments From dobey@free.fr  2003-11-13 17:21 -------
 Created an attachment (id=21424)
 Patch to fix the bug with buttons in notebook tab labels
 
+
+------- Additional Comments From sandmann@daimi.au.dk  2003-11-13 18:12 -------
+This patch makes sense to me. An active, RELIEF_NONE button that isn't
+depressed should probably not have a bevel drawn.
+
+The test in the patch is logically equivalent to
+
+     if (relief != none || 
+         (active && depressed) || prelighted || selected)
+            paint_box();
+
+which makes me wonder if it shouldn't simply be
+
+    if (relief != none || depressed || prelighted)
+           paint_box ();
+