Bug#241860: gtk+2.0: debian/rules file version-determining sed script needs tweak

Akira TAGOH Akira TAGOH <tagoh@debian.org>, 241860@bugs.debian.org
Mon, 05 Apr 2004 20:22:17 +0900 (JST)


>>>>> On Sat, 03 Apr 2004 07:00:29 -0700,
>>>>> "PV" == "Paul Varga" <pjvarga@qwest.net> wrote:

PV> Package: gtk+2.0
PV> Severity: minor
PV> Tags: experimental patch

PV> The "debian/rules" file's version-determining sed script needs the
PV> '-packageversion' and '+misc' removers transposed. Due to those two
PV> scripts checking that the replacement ends at the end of a line, they
PV> only work in last-to-first order. I discovered this when building a GTK+
PV> package using a patch I'd written; I used a '+1' suffix to mark the
PV> package as specially modified and this triggered the bug (which mangled
PV> "version" and "modver" pretty badly).

PV> I haven't checked if this applies to non-experimental GTK+ Debian
PV> packaging. Thought I might as well report it.

PV> An extremely simple patch is included as a more detailed answer.

Well, I can't change the order due to cover the case like
<upstream version>+<whatever>-<deb release>. but perhaps

version=$(shell dpkg-parsechangelog | grep '^Version: ' | sed -e 's/^Version: //' -e 's/-[A-Za-z0-9\.\+]*$$//g' -e 's/+[A-Za-z0-9\.]*$$//g')

should be good enough for you, I think.
does it make sense?

Regards,
--
Akira TAGOH  : tagoh@gnome.gr.jp  / Japan GNOME Users Group
at@gclab.org : tagoh@gnome-db.org / GNOME-DB Project
             : tagoh@redhat.com   / Red Hat, Inc.
             : tagoh@debian.org   / Debian Project