Bug#256335: marked as done (Bug report logs - #247198 Bug #247198: /var/lib/defoma/scripts/pango.defoma: missing escaping of regex)

Debian Bug Tracking System owner@bugs.debian.org
Fri, 06 Aug 2004 12:03:19 -0700


Your message dated Fri, 06 Aug 2004 14:47:11 -0400
with message-id <E1Bt9kF-0002SL-00@newraff.debian.org>
and subject line Bug#256335: fixed in pango1.0 1.4.1-1
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 26 Jun 2004 08:48:45 +0000
>From flavio.stanchina@tin.it Sat Jun 26 01:48:44 2004
Return-path: <flavio.stanchina@tin.it>
Received: from vsmtp12.tin.it [212.216.176.206] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Be8rc-0001MM-00; Sat, 26 Jun 2004 01:48:44 -0700
Received: from tin.it (82.50.46.231) by vsmtp12.tin.it (7.0.027)
        id 40B33B7C00778EDC; Sat, 26 Jun 2004 10:48:29 +0200
Message-ID: <40DD385C.6010409@tin.it>
Date: Sat, 26 Jun 2004 10:48:28 +0200
From: Flavio Stanchina <flavio.stanchina@tin.it>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040401 Debian/1.6-4
X-Accept-Language: en
MIME-Version: 1.0
CC: Akira TAGOH <tagoh@debian.org>,  submit@bugs.debian.org
Subject: Bug report logs - #247198
	Bug #247198: /var/lib/defoma/scripts/pango.defoma:
 missing escaping of regex
X-Enigmail-Version: 0.83.6.0
X-Enigmail-Supports: pgp-inline, pgp-mime
Content-Type: multipart/mixed;
 boundary="------------000000070607010104090207"
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-8.0 required=4.0 tests=BAYES_00,HAS_PACKAGE 
	autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

This is a multi-part message in MIME format.
--------------000000070607010104090207
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Package: libpango1.0-common
Version: 1.4.0-4
Severity: normal
Tags: patch

Your fix to bug #247198 in pango1.0 version 1.2.5-5 doesn't actually fix 
the unquoted string that's giving me problems, but another similar case 
that I missed. I sent a mail to 247198@bugs.debian.org to that effect, 
see: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=247198

But the BTS didn't reopen the bug as I wanted. I likely made a mistake 
in my mail, I'm not proficient in using the BTS, then I forgot about 
this issue so the bug is now archived and I don't think it can be reopened.

A new, hopefully final, patch is attached. Please apply.

-- 
Ciao, Flavio


--------------000000070607010104090207
Content-Type: text/plain;
 name="pango.defoma.patch-v2"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="pango.defoma.patch-v2"

--- pango.defoma	2004-06-09 00:33:48.000000000 +0200
+++ pango.defoma-patch-v2	2004-05-10 11:56:06.000000000 +0200
@@ -72,25 +72,24 @@
 
 	foreach my $i (@cache) {
 		my $font = $Id->{1}->[$i];
-		my $enc;
+		my $enc = "$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}";
 		$font =~ s/_/ /g;
 		$xe = get_xlfd_element ($font);
 		$xlfd = generate_xlfd ($xe);
 
 		if ($xe->{Weight} =~ /bold/ && ($xe->{Slant} eq 'o' || $xe->{Slant} eq 'i')) {
-			$enc = "$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}";
 			push (@inbn_xlfd, $xlfd) if (!grep (/\Q$enc/, @inbn_xlfd));
 			next;
 		}
 		if ($xe->{Weight} !~ /bold/ && ($xe->{Slant} eq 'o' || $xe->{Slant} eq 'i')) {
-			push (@innn_xlfd, $xlfd) if (!grep (/$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}/, @innn_xlfd));
+			push (@innn_xlfd, $xlfd) if (!grep (/\Q$enc/, @innn_xlfd));
 			next;
 		}
 		if ($xe->{Weight} =~ /bold/ && $xe->{Slant} =~ /r/) {
-			push (@nnbn_xlfd, $xlfd) if (!grep (/$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}/, @nnbn_xlfd));
+			push (@nnbn_xlfd, $xlfd) if (!grep (/\Q$enc/, @nnbn_xlfd));
 			next;
 		}
-		push (@nnnn_xlfd, $xlfd) if (!grep (/$xe->{Foundry}-$xe->{Family}-$xe->{Encoding}/, @nnnn_xlfd));
+		push (@nnnn_xlfd, $xlfd) if (!grep (/\Q$enc/, @nnnn_xlfd));
 	}
 	return \(@nnnn_xlfd, @innn_xlfd, @nnbn_xlfd, @inbn_xlfd);
 }

--------------000000070607010104090207--

---------------------------------------
Received: (at 256335-close) by bugs.debian.org; 6 Aug 2004 18:53:58 +0000
>From katie@ftp-master.debian.org Fri Aug 06 11:53:58 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1Bt9qo-0002bK-00; Fri, 06 Aug 2004 11:53:58 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1Bt9kF-0002SL-00; Fri, 06 Aug 2004 14:47:11 -0400
From: jdassen@debian.org (J.H.M. Dassen (Ray))
To: 256335-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#256335: fixed in pango1.0 1.4.1-1
Message-Id: <E1Bt9kF-0002SL-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Fri, 06 Aug 2004 14:47:11 -0400
Delivered-To: 256335-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-4.3 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
	NO_DNS_FOR_FROM autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 
X-CrossAssassin-Score: 2

Source: pango1.0
Source-Version: 1.4.1-1

We believe that the bug you reported is fixed in the latest version of
pango1.0, which is due to be installed in the Debian FTP archive:

libpango1.0-0_1.4.1-1_i386.deb
  to pool/main/p/pango1.0/libpango1.0-0_1.4.1-1_i386.deb
libpango1.0-common_1.4.1-1_i386.deb
  to pool/main/p/pango1.0/libpango1.0-common_1.4.1-1_i386.deb
libpango1.0-dbg_1.4.1-1_i386.deb
  to pool/main/p/pango1.0/libpango1.0-dbg_1.4.1-1_i386.deb
libpango1.0-dev_1.4.1-1_i386.deb
  to pool/main/p/pango1.0/libpango1.0-dev_1.4.1-1_i386.deb
libpango1.0-doc_1.4.1-1_all.deb
  to pool/main/p/pango1.0/libpango1.0-doc_1.4.1-1_all.deb
libpango1.0-udeb_1.4.1-1_i386.udeb
  to pool/main/p/pango1.0/libpango1.0-udeb_1.4.1-1_i386.udeb
pango1.0_1.4.1-1.diff.gz
  to pool/main/p/pango1.0/pango1.0_1.4.1-1.diff.gz
pango1.0_1.4.1-1.dsc
  to pool/main/p/pango1.0/pango1.0_1.4.1-1.dsc
pango1.0_1.4.1.orig.tar.gz
  to pool/main/p/pango1.0/pango1.0_1.4.1.orig.tar.gz



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 256335@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
J.H.M. Dassen (Ray) <jdassen@debian.org> (supplier of updated pango1.0 package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri,  6 Aug 2004 20:31:25 +0200
Source: pango1.0
Binary: libpango1.0-dev libpango1.0-0 libpango1.0-doc libpango1.0-udeb libpango1.0-dbg libpango1.0-common
Architecture: source i386 all
Version: 1.4.1-1
Distribution: unstable
Urgency: medium
Maintainer: J.H.M. Dassen (Ray) <jdassen@debian.org>
Changed-By: J.H.M. Dassen (Ray) <jdassen@debian.org>
Description: 
 libpango1.0-0 - Layout and rendering of internationalized text
 libpango1.0-common - Modules and configuration files for the Pango
 libpango1.0-dbg - The Pango library and debugging symbols
 libpango1.0-dev - Development files for the Pango
 libpango1.0-doc - Documentation files for the Pango
 libpango1.0-udeb - Layout and rendering of internationalized text (udeb)
Closes: 255130 256335
Changes: 
 pango1.0 (1.4.1-1) unstable; urgency=medium
 .
   * New upstream release. Changes include:
     * Fix common crash in Hangul shaper [Changwoo Ryu] (Closes: #255130)
   * [debian/pango.defoma] Applied regex escaping patch courtesy of Flavio
     Stanchina <flavio.stanchina@tin.it> and fixed its logic. (Closes: #256335)
Files: 
 8ba9add2adabe3466b2fbd5d03f12e20 1704 libs optional pango1.0_1.4.1-1.dsc
 298061652b5e722f4bab54a3861ee459 1261205 libs optional pango1.0_1.4.1.orig.tar.gz
 cd8cc97793f6beee9379d13f4fb32bed 29405 libs optional pango1.0_1.4.1-1.diff.gz
 8ed1182705bd114aa9fa974e201799ca 142130 doc optional libpango1.0-doc_1.4.1-1_all.deb
 29ba377abf19ac6ecf3de67b51f8a884 245784 libs optional libpango1.0-0_1.4.1-1_i386.deb
 232e431c27c2218739630a0de28902e9 16904 misc optional libpango1.0-common_1.4.1-1_i386.deb
 8f60bebc265e7ad454f07bb69bb457eb 257414 libdevel optional libpango1.0-dev_1.4.1-1_i386.deb
 fcef3cb7706eb7f2435522216e8c1f27 983032 libdevel extra libpango1.0-dbg_1.4.1-1_i386.deb
 dd08351747e532fd7f181a411eb58cfe 1015762 debian-installer optional libpango1.0-udeb_1.4.1-1_i386.udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFBE9EG/HzwHc5k3nkRAkKpAJ4iQlQVyDmxUr7a52EJPGGOaJQujACcCPq0
/Cb12ayLVnH0g6ESeibRz38=
=EKKh
-----END PGP SIGNATURE-----