[Bug 129789] starts playing when you click Next or Previous while paused

[bugzilla-daemon@bugzilla.gnome.org]

http://bugzilla.gnome.org/show_bug.cgi?id=129789
rhythmbox | General | Ver: 0.8.8

lool+gnome@via.ecp.fr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.6.1                       |0.8.8



------- Additional Comments From lool+gnome@via.ecp.fr  2004-12-12 15:47 -------
(Setting version accordingly.)

I find the patch rather clean, I tried understanding the call stacks involved in
rb_shell_player_do_next() and rb_shell_player_do_previous(), and while some
things are completely obscure to me, I think that the approach of this patch is:
- in _do_next() and _do_previous() replace calls to a function which did simply
request for something to be played (rb_shell_player_set_playing_entry) by a
function which do the same request but save playing state prior to the call, and
restores it afterwards (rb_shell_player_set_entry_with_current_state),
- remove all things which caused play to be started from
rb_shell_player_set_playing_entry to make a rb_shell_player_set_entry out of it,
- rb_shell_player_set_playing_entry is redefined to call
rb_shell_player_set_entry and set state to playing.
- remove the borken save playing state code from "rb_shell_player_open_location".

Does anything prevents this patch from inclusion?

------- You are receiving this mail because: -------
You are on the CC list for the bug.