[Bug 133120] Changed - wrong focus when changing workspace

bugzilla-daemon@widget.gnome.org bugzilla-daemon@widget.gnome.org
Mon, 2 Feb 2004 00:29:17 -0500 (EST)

Please do not reply to this email- if you want to comment on the bug, go to the
URL shown below and enter your comments there.


Changed by bugsqueesher@yahoo.com.

--- shadow/133120	Sun Feb  1 09:46:25 2004
+++ shadow/133120.tmp.18536	Mon Feb  2 00:29:17 2004
@@ -10,13 +10,13 @@
 Component: general
 AssignedTo: metacity-maint@bugzilla.gnome.org                            
 ReportedBy: seb128@debian.org               
 QAContact: metacity-qa-maint@bugzilla.gnome.org
 TargetMilestone: ---
-Cc: pkg-gnome-maintainers@lists.alioth.debian.org
+Cc: bugsqueesher@yahoo.com,pkg-gnome-maintainers@lists.alioth.debian.org
 Summary: wrong focus when changing workspace
 This bug was originally reported in the Debian BTS:
 "I've got the same problem using 2.6.3 :-(. Autorise is off and it also
@@ -38,6 +38,24 @@
 over the background the focus stays on the terminal window as it's kind of
    - Now, with the mouse OVER the background (not the focused window) move
 to another workspace (using the KEYS) and go back to the previous
 workspace. The result is that NO window is focused even that the terminal
 is the only window in the workspace."
+------- Additional Comments From bugsqueesher@yahoo.com  2004-02-02 00:29 -------
+I believe this occurs because
+workspace.c:meta_workspace_activate_with_focus calls
+meta_workspace_focus_default window.  Replacing it with
+meta_workspace_focus_mru_window would be wrong because if the mouse
+enters a window upon switching workspaces, then it should be focused.
+ Thus, the behavior I believe you want is to focus the 'default'
+window if one is found and otherwise to focus the 'MRU' (most recently
+used) window.  Doing this would require a new function (although it'd
+be trivial to write as it's mostly just cut and paste from the two
+previously mentioned existing functions).  Note that this would only
+be for sloppy focus and NOT for mouse focus, because for mouse focus
+we really don't want a window focused if the pointer isn't in it.
+I don't care too much either way (since I use mouse focus), but if the
+Metacity maintainers would like this then I'll write a patch for it;
+it should be fairly simple.