Bug#256848: marked as done (html2xml.py does not close <sub>)

Debian Bug Tracking System owner@bugs.debian.org
Fri, 02 Jul 2004 14:03:27 -0700


Your message dated Fri, 02 Jul 2004 16:47:04 -0400
with message-id <E1BgUw4-00051K-00@newraff.debian.org>
and subject line Bug#256848: fixed in devhelp 0.9-8
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 29 Jun 2004 13:39:25 +0000
>From richard@daijobu.co.uk Tue Jun 29 06:39:25 2004
Return-path: <richard@daijobu.co.uk>
Received: from h36.rdg.cp.net (n082.sc1.cp.net) [209.228.29.85] 
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BfIpZ-0002TL-00; Tue, 29 Jun 2004 06:39:25 -0700
Received: from carmen (81.101.64.8) by n082.sc1.cp.net (7.0.027.3-1)
        id 40DCD8AB0008E6D7 for submit@bugs.debian.org; Tue, 29 Jun 2004 13:39:21 +0000
Received: from localhost
	([127.0.0.1] helo=daijobu.co.uk ident=richard)
	by carmen with esmtp (Exim 3.36 #1 (Debian))
	id 1BfImZ-00073i-00
	for <submit@bugs.debian.org>; Tue, 29 Jun 2004 14:36:19 +0100
Message-ID: <40E17052.2030205@daijobu.co.uk>
Date: Tue, 29 Jun 2004 14:36:18 +0100
From: Richard Cohen <richard@daijobu.co.uk>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040413 Debian/1.6-5
X-Accept-Language: en
MIME-Version: 1.0
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: html2xml.py does not close <sub>
Content-Type: multipart/mixed;
 boundary="------------080304020409090804000505"
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.5 required=4.0 tests=BAYES_00,HAS_PACKAGE,
	HTML_10_20,HTML_MESSAGE autolearn=no 
	version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

This is a multi-part message in MIME format.
--------------080304020409090804000505
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Package: devhelp
Version: 0.9-5
Severity: normal
Tags: patch

The script html2xml.py doesn't close the <sub> tag if it has no 
sub-<sub>s and devhelp will complain

For example,
$ cd /usr/share/doc/
$ python devhelp/tools/html2xml.py libgtk2.0-doc/gtk-faq
...
   <sub name="GTK+ FAQ Contributions, Maintainers and Copyright" 
link="c958.html"></chapters>

</book>

Patch is mostly re-indenting

-- System Information:
Debian Release: testing/unstable
   APT prefers testing
   APT policy: (990, 'testing'), (101, 'experimental'), (101, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.7
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8

Versions of packages devhelp depends on:
ii  libatk1.0-0                 1.6.1-2      The ATK accessibility toolkit
ii  libc6                       2.3.2.ds1-13 GNU C Library: Shared 
libraries an
ii  libdevhelp-1-0              0.9-5        Library providing 
documentation br
ii  libglib2.0-0                2.4.2-1      The GLib library of C routines
ii  libgnome2-0                 2.6.1-5      The GNOME 2 library - 
runtime file
ii  libgnomeui-0                2.6.1.1-2    The GNOME 2 libraries (User 
Interf
ii  libgtk2.0-0                 2.4.3-1      The GTK+ graphical user 
interface
ii  libpango1.0-0               1.4.0-4      Layout and rendering of 
internatio
ii  libxml2                     2.6.10-3     GNOME XML library

-- no debconf information

--------------080304020409090804000505
Content-Type: text/x-patch;
 name="html2xml.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="html2xml.diff"

--- html2xml.py	2004-04-20 19:55:14.000000000 +0100
+++ html2xml.py	2004-06-29 14:33:56.000000000 +0100
@@ -131,17 +131,17 @@
 print '<chapters>'
 for chap in dict['order']:
     print '  <sub name="%s" link="%s">' % (chap, dict[chap]['link'])
-    if not dict[chap].has_key ('order'):
-	continue
-    for sub in dict[chap]['order']:
-	if not does_dict_have_keys (dict[chap][sub], ['link']):
-	    print '    <sub name="%s" link="%s">' % (sub, dict[chap][sub]['link'])
+    if dict[chap].has_key ('order'):
+        for sub in dict[chap]['order']:
+            if not does_dict_have_keys (dict[chap][sub], ['link']):
+                print '    <sub name="%s" link="%s">' % (sub, dict[chap][sub]['link'])
 	    
-	    for sub2 in dict[chap][sub]['order']:
-		print '      <sub name="%s" link="%s"/>' % (sub2, dict[chap][sub][sub2]['link'])
-            print '    </sub>'
-	else:
-	    print '    <sub name="%s" link="%s"/>' % (sub, dict[chap][sub]['link'])	    
+                for sub2 in dict[chap][sub]['order']:
+                    print '      <sub name="%s" link="%s"/>' % (sub2, dict[chap][sub][sub2]['link'])
+                print '    </sub>'
+            else:
+                print '    <sub name="%s" link="%s"/>' % (sub, dict[chap][sub]['link'])
+                    
     print '  </sub>'
     print
     

--------------080304020409090804000505--

---------------------------------------
Received: (at 256848-close) by bugs.debian.org; 2 Jul 2004 20:53:05 +0000
>From katie@ftp-master.debian.org Fri Jul 02 13:53:05 2004
Return-path: <katie@ftp-master.debian.org>
Received: from newraff.debian.org [208.185.25.31] (mail)
	by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
	id 1BgV1t-000129-00; Fri, 02 Jul 2004 13:53:05 -0700
Received: from katie by newraff.debian.org with local (Exim 3.35 1 (Debian))
	id 1BgUw4-00051K-00; Fri, 02 Jul 2004 16:47:04 -0400
From: Gustavo Noronha Silva <kov@debian.org>
To: 256848-close@bugs.debian.org
X-Katie: $Revision: 1.51 $
Subject: Bug#256848: fixed in devhelp 0.9-8
Message-Id: <E1BgUw4-00051K-00@newraff.debian.org>
Sender: Archive Administrator <katie@ftp-master.debian.org>
Date: Fri, 02 Jul 2004 16:47:04 -0400
Delivered-To: 256848-close@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25 
	(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-4.5 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER,
	HTML_MESSAGE autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level: 

Source: devhelp
Source-Version: 0.9-8

We believe that the bug you reported is fixed in the latest version of
devhelp, which is due to be installed in the Debian FTP archive:

devhelp-common_0.9-8_all.deb
  to pool/main/d/devhelp/devhelp-common_0.9-8_all.deb
devhelp_0.9-8.diff.gz
  to pool/main/d/devhelp/devhelp_0.9-8.diff.gz
devhelp_0.9-8.dsc
  to pool/main/d/devhelp/devhelp_0.9-8.dsc
devhelp_0.9-8_i386.deb
  to pool/main/d/devhelp/devhelp_0.9-8_i386.deb
libdevhelp-1-0_0.9-8_i386.deb
  to pool/main/d/devhelp/libdevhelp-1-0_0.9-8_i386.deb
libdevhelp-1-dev_0.9-8_i386.deb
  to pool/main/d/devhelp/libdevhelp-1-dev_0.9-8_i386.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 256848@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Gustavo Noronha Silva <kov@debian.org> (supplier of updated devhelp package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.7
Date: Fri,  2 Jul 2004 17:04:50 -0300
Source: devhelp
Binary: libdevhelp-1-0 devhelp-common devhelp libdevhelp-1-dev
Architecture: source all i386
Version: 0.9-8
Distribution: unstable
Urgency: low
Maintainer: Gustavo Noronha Silva <kov@debian.org>
Changed-By: Gustavo Noronha Silva <kov@debian.org>
Description: 
 devhelp    - A GNOME developers help program
 devhelp-common - common files for devhelp and its library
 libdevhelp-1-0 - Library providing documentation browser functionality
 libdevhelp-1-dev - Library providing documentation browser functionality (developmen
Closes: 256848 256852 257177
Changes: 
 devhelp (0.9-8) unstable; urgency=low
 .
   * debian/devhelp.postinst -> debian/libdevhelp-1-0.postinst:
   - the package that provides the schema file should be
     the one installing it!
   * debian/rules:
   - create shlibs.local to override dependency information
     for libdevhelp-1-0, so that devhelp will depend on the
     exact version of the library  (Closes: #256852)
   - moved the command that copies the elisp file to debian/
     to a pre-build:: rule, so it will be there when dh_installemacsen
     runs (Closes: #257177)
   * debian/control.in:
   - replaced all 'DevHelp' ocurrences with 'Devhelp', as it seems
     to be the "official" name given upstream.
   * debian/patches/02relibtoolize.diff:
   - renamed to end with .patch instead, to be consistent with
     the other ones
   * debian/patches/03html2diff_close_sub.patch:
   - adding patch from Richard Cohen <richard@daijobu.co.uk>
     for html2xml.py to close <sub> tags (Closes: #256848)
   * debian/patches/04book_search_path_fix.patch:
   - adding patch from upstream's CVS to have ~/.devhelp
     override system-wide books in case of duplicates and
     to avoid '.' and '..' while searching for books.
Files: 
 30e4e9d486f0cd28a3ee6fac6941ffec 1596 devel optional devhelp_0.9-8.dsc
 189a4d27604cb550312d1541b04f842e 173038 devel optional devhelp_0.9-8.diff.gz
 c3951a33d57ffc2719c0536df868f6e3 63342 devel optional devhelp-common_0.9-8_all.deb
 a05385e771dbafc6741387f68867a1ce 60018 libs optional libdevhelp-1-0_0.9-8_i386.deb
 55fa3ec148d1938b37de1e5b7c7b7321 62820 libdevel optional libdevhelp-1-dev_0.9-8_i386.deb
 876a7d9b93cad0da9f9686071623ef20 45540 devel optional devhelp_0.9-8_i386.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA5cYNt1anjIgqbEsRAu7vAJ449JJuoAlL6QNJd+VbAesH4YuIowCfez3K
fVE24FQSLEDyJMqGb4CwBF0=
=cN33
-----END PGP SIGNATURE-----