Bug#254838: parsing problem in /etc/gdm/Sessions/Gnome (UMASK incorrect)

[Jerome Warnier]

Package: gdm
Version: 2.4.4.7-3
Severity: normal

There is a parsing problem in /etc/gdm/Sessions/Gnome.
I commented out the UMASK line in /etc/login.defs and added a new line
reading "UMASK 002".
The problem is that the haveloginoption() function checks if a line not
commented exists in /etc/login.defs (ie starting with "UMASK"), but
then, the loginoptionvalue() doesn't check if the first occurence of
"UMASK" in /etc/login.defs is the uncommented one. This leads to UMASK
being set to the commented value!!

The same problem will occur with UMASK, ULIMIT, MAIL_DIR, and MAIL_FILE
at least.

I do not feel at ease enough with awk to submit a patch, but I could
probably replace it with sed and cut if you want me to.

Thanks

-- System Information:
Debian Release: testing/unstable
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.4.26-1-k7-smp
Locale: LANG=C, LC_CTYPE=C

Versions of packages gdm depends on:
ii  adduser                   3.56           Add and remove users and groups
ii  debconf                   1.4.25         Debian configuration management sy
ii  dpkg                      1.10.22        Package maintenance system for Deb
ii  gksu                      1.0.7-1        graphical frontend to su
ii  gnome-session             2.4.2-5        The GNOME 2 Session Manager
ii  gnome-terminal [x-termina 2.4.2-7        The GNOME 2 terminal emulator appl
ii  libart-2.0-2              2.3.16-5       Library of functions for 2D graphi
ii  libatk1.0-0               1.6.1-2        The ATK accessibility toolkit
ii  libattr1                  2.4.16-1       Extended attribute shared library
ii  libbonobo2-0              2.6.0-2        Bonobo CORBA interfaces library
ii  libbonoboui2-0            2.4.3-2        The Bonobo UI library
ii  libc6                     2.3.2.ds1-12   GNU C Library: Shared libraries an
ii  libgconf2-4               2.4.0.1-4      GNOME configuration database syste
ii  libglade2-0               1:2.0.1-13     Library to load .glade files at ru
ii  libglib2.0-0              2.4.2-1        The GLib library of C routines
ii  libgnome2-0               2.4.0-11       The GNOME 2 library - runtime file
ii  libgnomecanvas2-0         2.4.0-3        A powerful object-oriented display
ii  libgnomeui-0              2.4.0.1-12     The GNOME 2 libraries (User Interf
ii  libgnomevfs2-0            2.4.1-5        The GNOME virtual file-system libr
ii  libgnomevfs2-common       2.4.1-5        The GNOME virtual file-system libr
ii  libgsf-1                  1.9.0-1        Structured File Library - runtime 
ii  libgtk2.0-0               2.2.4-6        The GTK+ graphical user interface 
ii  libice6                   4.3.0.dfsg.1-4 Inter-Client Exchange library
ii  liborbit2                 1:2.10.2-1.1   libraries for ORBit2 - a CORBA ORB
ii  libpam-modules            0.76-21        Pluggable Authentication Modules f
ii  libpam-runtime            0.76-21        Runtime support for the PAM librar
ii  libpam0g                  0.76-21        Pluggable Authentication Modules l
ii  libpango1.0-0             1.4.0-4        Layout and rendering of internatio
ii  libpopt0                  1.7-4          lib for parsing cmdline parameters
ii  librsvg2-2                2.5.0-2        SAX-based renderer library for SVG
ii  libselinux1               1.12-1         SELinux shared libraries
ii  libsm6                    4.3.0.dfsg.1-4 X Window System Session Management
ii  libwrap0                  7.6.dbs-4      Wietse Venema's TCP wrappers libra
ii  libx11-6                  4.3.0.dfsg.1-4 X Window System protocol client li
ii  libxext6                  4.3.0.dfsg.1-4 X Window System miscellaneous exte
ii  libxml2                   2.6.10-3       GNOME XML library
ii  metacity [x-window-manage 1:2.6.5-1      A lightweight GTK2 based Window Ma
ii  xbase-clients             4.3.0.dfsg.1-4 miscellaneous X clients
ii  xlibs                     4.3.0.dfsg.1-4 X Window System client libraries m
ii  xterm [x-terminal-emulato 4.3.0.dfsg.1-4 X terminal emulator
ii  zlib1g                    1:1.2.1.1-3    compression library - runtime

-- debconf information:
  gdm/daemon_name: /usr/bin/gdm
* shared/default-x-display-manager: gdm